Skip to content

Commit

Permalink
refactor(menu): improve chromatic cov, prevent checkbox + icon clash(#…
Browse files Browse the repository at this point in the history
…2757)

- refactor menu item

- create single menu item story
- create menu with variants story
- build chromatic testing views for menu item and menu with variants
- remove extra stories in favor of using menu with variants

- fix to prevent multiselect checkbox and icon clash

CSS-614
  • Loading branch information
rise-erpelding committed May 23, 2024
1 parent 50a779f commit e945e26
Show file tree
Hide file tree
Showing 4 changed files with 673 additions and 363 deletions.
7 changes: 7 additions & 0 deletions .changeset/silly-ties-attend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/menu": patch
---

Prevents overlap of checkbox and icon if both are used in a menu item.

Also reduces a significant number of variants by consolidating menus, includes a refactor to enhance menu item understanding, and expands Chromatic testing coverage.
2 changes: 1 addition & 1 deletion components/menu/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ governing permissions and limitations under the License.
}

.is-selectableMultiple .spectrum-Menu-itemCheckbox {
grid-area: iconArea;
grid-area: checkmarkArea;
}

.spectrum-Menu-checkmark {
Expand Down
Loading

0 comments on commit e945e26

Please sign in to comment.