Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox|Radio] Mismatch in "fill" styling #1035

Closed
Westbrook opened this issue Oct 5, 2020 · 3 comments
Closed

[Checkbox|Radio] Mismatch in "fill" styling #1035

Westbrook opened this issue Oct 5, 2020 · 3 comments
Labels
bug Results from a bug in the CSS implementation

Comments

@Westbrook
Copy link
Contributor

Description

Unclear whether this is intended or not, but I was surprised to see the fill styling of the radio and the checkbox patterns diverge:

image
image

Is this to be expected, or is this something that will wash out of later beta releases?

https://opensource.adobe.com/spectrum-css/checkbox.html
https://opensource.adobe.com/spectrum-css/radio.html
@Westbrook Westbrook added the bug Results from a bug in the CSS implementation label Oct 5, 2020
@lazd
Copy link
Member

lazd commented Oct 5, 2020

Looks like this is due to #349

@Westbrook
Copy link
Contributor Author

That looks like the ticket. Thanks!

Feel free to close as duplicate as you'd prefer.

@lazd
Copy link
Member

lazd commented Oct 19, 2020

Closing in favor of #349, new PR #1057 will address this issue. Thanks!

@lazd lazd closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazd @Westbrook