Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Checkbox/Radio emphasized variant #1057

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

lazd
Copy link
Member

@lazd lazd commented Oct 19, 2020

Description

Correct Checkbox and Radio to have a standard color by default, add emphasized variant.

This work was already done in some form here c8db570, but it seems to have been lost.

Screenshots

image
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

BREAKING CHANGE: colors change in a way that may be unexpected

docs: add docs explaining quiet/emphasized Checkbox/Radio
@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@lazd lazd requested review from GarthDB and jianliao October 19, 2020 19:26
@lazd
Copy link
Member Author

lazd commented Oct 19, 2020

This may anger the masses, but it is the will of Spectrum.

cc @dannify @devongovett @snowystinger

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

Copy link
Contributor

@jianliao jianliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianliao jianliao merged commit 3ac8b31 into spectrum-tokens-18 Oct 19, 2020
@GarthDB GarthDB deleted the checkbox-emphasized branch September 30, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants