Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu icons need their own classes #202

Closed
lazd opened this issue Jun 6, 2019 · 0 comments
Closed

Menu icons need their own classes #202

lazd opened this issue Jun 6, 2019 · 0 comments
Labels
breaking change Results in a breaking API change
Milestone
V3

Comments

@lazd
Copy link
Member

lazd commented Jun 6, 2019

Right now, menu icons are just targeting .spectrum-Icon, when they should target .spectrum-Menu-itemIcon.
@lazd lazd added the breaking change Results in a breaking API change label Jun 6, 2019
@lazd lazd added this to the V3 milestone Jun 6, 2019
Martskin added a commit to Martskin/spectrum-css that referenced this issue Oct 14, 2019
@Martskin
chore: adds menu item class for issue adobe#202
ef0d6f4
@Martskin Martskin mentioned this issue Oct 14, 2019
Merged
@lazd lazd closed this as completed in 169940a Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Results in a breaking API change
Projects
None yet
Milestone
V3
Development

No branches or pull requests
1 participant
@lazd