Font fallbacks #248
Merged
Font fallbacks #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tappily
reviewed
Aug 21, 2019
components/commons/fonts.css
Outdated
| --spectrum-font-family-he: 'adobe-hebrew', var(--spectrum-font-fallbacks-sans); | ||
| --spectrum-font-family-zhhans: 'adobe-clean-han-simplified-c', 'SimSun', 'Heiti SC Light', var(--spectrum-font-fallbacks-sans); | ||
| --spectrum-font-family-zh: var(--spectrum-font-family-zhhans); | ||
| --spectrum-font-family-zhhant: 'adobe-clean-han-traditional', 'MingLiu', 'Heiti TC Light', var(--spectrum-font-fallbacks-sans); |
There was a problem hiding this comment.
Looking at MingLiu, I'd prefer we have a gothic option here instead. I looks like we get 'JhengHei UI' and 'JhengHei' installed from the Microsoft Store when we enable Chinese Typography in Windows 10 (although it's not clearly documented :-/ ).
There was a problem hiding this comment.
Thanks @tappily! Are you suggesting we change it to:
--spectrum-font-family-zhhant: adobe-clean-han-traditional', 'JhengHei UI', 'JhengHei', 'MingLiu', 'Heiti TC Light', var(--spectrum-font-fallbacks-sans);
Let me know and I'll make the change.
There was a problem hiding this comment.
Close. I'd prefer MingLui not be in this list at all. MingLui works for the article/ serif style, but not here.
There was a problem hiding this comment.
@tappily ok, updated! Are we good to go?
There was a problem hiding this comment.
Sorry, i missed the MS prefix. needs to be "Microsoft JhengHei UI" and "Microsoft JhengHei"
lazd
added a commit
that referenced
this pull request
Aug 23, 2019
* New, responsive site based on individually versioned components with silly fast navigation, lazy loaded deps as docs are viewed * Basic accessible search with build-time index generation * Update README for individual versioning, add legacy README with legacy usage * Add documentation for site updating and architecture * Add docs for documentation generation, link to docs, remove references to Precursors * Add instructions for adding/editing components * Add docs to show how to update DNA and icons * Add docs for getting DNA variables from @spectrum-css/vars * Document issues with npm ci and installing optional dependencies * Update to DNA 5.18.1 * Update icons to 4.1.0 * Audit DNA status for all components * Add nvmrc * Export a experimental tree-shakable DNA variable object from @spectrum-css/vars * Update Textarea line-height and min-height, closes #231 * Fix spinner buttons appearing on Steppers in Firefox, closes #214 * Fix search field on iOS, closes #229 * Fix Menu chevron vertical alignment, fixes #240 * Fix horizontal alignment of labels in anchor buttons, fixes #239 * Remove button outline when focused in Firefox, fixes #161 * Fix bar loader label in IE 11, fixes #242 * Fix Radio label margins when labels are below, fixes #246 * Fix Checkbox icon color when checkbox imported before icons, fixes #219 (#235) * Add Adobe Clean UX support, closes #189 (#248) * Fix fallback fonts for ar, he, ja, zh-Hans, zh-Hant, and ko, closes #232 (#248) * Removed float from tags, fixes #218 (#237) * Make Slider grab handle look right in docs, closes #255 * Add missing Asset docs, closes #256 * Add Menu .is-highlighted so we can indicate highlight without mis-using .is-open, closes #258 * Support using links as menu items, closes #257 * Fix incorrect height for small BarLoader, fixes #259
1 task
jianliao
pushed a commit
that referenced
this pull request
Aug 27, 2019
* New, responsive site based on individually versioned components with silly fast navigation, lazy loaded deps as docs are viewed * Basic accessible search with build-time index generation * Update README for individual versioning, add legacy README with legacy usage * Add documentation for site updating and architecture * Add docs for documentation generation, link to docs, remove references to Precursors * Add instructions for adding/editing components * Add docs to show how to update DNA and icons * Add docs for getting DNA variables from @spectrum-css/vars * Document issues with npm ci and installing optional dependencies * Update to DNA 5.18.1 * Update icons to 4.1.0 * Audit DNA status for all components * Add nvmrc * Export a experimental tree-shakable DNA variable object from @spectrum-css/vars * Update Textarea line-height and min-height, closes #231 * Fix spinner buttons appearing on Steppers in Firefox, closes #214 * Fix search field on iOS, closes #229 * Fix Menu chevron vertical alignment, fixes #240 * Fix horizontal alignment of labels in anchor buttons, fixes #239 * Remove button outline when focused in Firefox, fixes #161 * Fix bar loader label in IE 11, fixes #242 * Fix Radio label margins when labels are below, fixes #246 * Fix Checkbox icon color when checkbox imported before icons, fixes #219 (#235) * Add Adobe Clean UX support, closes #189 (#248) * Fix fallback fonts for ar, he, ja, zh-Hans, zh-Hant, and ko, closes #232 (#248) * Removed float from tags, fixes #218 (#237) * Make Slider grab handle look right in docs, closes #255 * Add missing Asset docs, closes #256 * Add Menu .is-highlighted so we can indicate highlight without mis-using .is-open, closes #258 * Support using links as menu items, closes #257 * Fix incorrect height for small BarLoader, fixes #259
jianliao
pushed a commit
that referenced
this pull request
Sep 19, 2019
Update Textarea line-height and min-height, closes #231 Fix spinner buttons appearing on Steppers in Firefox, closes #214 Fix search field on iOS, closes #229 Fix Menu chevron vertical alignment, fixes #240 Fix horizontal alignment of labels in anchor buttons, fixes #239 Remove button outline when focused in Firefox, fixes #161 Fix bar loader label in IE 11, fixes #242 Fix Radio label margins when labels are below, fixes #246 Fix Checkbox icon color when checkbox imported before icons, fixes #219 (#235) Add Adobe Clean UX support, closes #189 (#248) Fix fallback fonts for ar, he, ja, zh-Hans, zh-Hant, and ko, closes #232 (#248) Removed float from tags, fixes #218 (#237) Make Slider grab handle look right in docs, closes #255 Add missing Asset docs, closes #256 Add Menu .is-highlighted so we can indicate highlight without mis-using .is-open, closes #258 Support using links as menu items, closes #257 Fix incorrect height for small BarLoader, fixes #259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes fallback fonts for Adobe Clean UX as well as ar, he, ja, zh-Hans, zh-Hant, and ko.
Related Issue
#189
#232
How Has This Been Tested?
Examples have been added for Hebrew that show the new fonts in action. Additionally, the fallbacks for ja, zh-Hans, zh-Hant, and ko have been confirmed with @yloubry
Types of changes