Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to individually versioned packages with Lerna #265

Merged
merged 330 commits into from
Sep 19, 2019
Merged

Move to individually versioned packages with Lerna #265

merged 330 commits into from
Sep 19, 2019

Conversation

lazd
Copy link
Member

@lazd lazd commented Aug 27, 2019

Todo

Description

Move to individually versioned packages with Lerna #179

Documentation

  • New, responsive site based on individually versioned components with silly fast navigation, lazy loaded deps as docs are viewed
    • Basic accessible search with build-time index generation
  • Update README for individual versioning, add legacy README with legacy usage
    • Add documentation for site updating and architecture
    • Add docs for documentation generation, link to docs, remove references to Precursors
    • Add instructions for adding/editing components
    • Add docs to show how to update DNA and icons
    • Add docs for getting DNA variables from @spectrum-css/vars
    • Document issues with npm ci and installing optional dependencies
  • IE 11 site support SDS-2082
    • using legacy multi-stop strategy instead of the CSS custom properties strategy.
    • On DOMContentLoaded, we check for custom properties support with CSS.supports() and swap out CSS files if its not supported. This means that index.vars does still get requested by the browser, but is replaced before load.
    • In addition, search and asynchronous fast page load are disabled as they use HTML5 and ES6 features not supported in IE and are not required for testing.
    • Added gulp devHeavy to build multistops for testing in IE

Chores

  • Update to DNA 5.18.1
  • Update icons to 4.1.0
  • Audit DNA status for all components
  • Add nvmrc
  • Export a experimental tree-shakable DNA variable object from @spectrum-css/vars

Bug fixes

Testing

Currently in use in React Spectrum master: https://github.com/adobe/react-spectrum/

React Spectrum storybook with 2.14.0-alpha.16: http://lfbuild.corp.adobe.com:8080/job/adobe/job/react-spectrum/job/master/124/Report_20adobe_20public_2fstorybook/


Branch in Angular Spectrum: https://git.corp.adobe.com/AMO/ngx-spectrum-components/tree/verify_ivc_spectrum

A diff script is included that diffs the component build files against 2.13. To run it:

npm install -g prettier
npm install
gulp
cd bundles/spectrum-css-compat
gulp
./diff.sh

Basic Create React App POC testing implementation in React / JavaScript / HTML5:
https://git.corp.adobe.com/bschmidt/spectrum-css-individual-versioning-poc-SDS-1812
Ticket: SDS-1812

Types of changes

  • New feature (non-breaking change which adds functionality)

lazd added 30 commits July 11, 2019 16:19
… are viewed (this probably needs an onload for the link to prevent FOUC)
…, it seems, and require.resolve() can't find them)
lazd and others added 25 commits September 18, 2019 17:34
support linking between bundle changelogs and component changelogs
lots of pretty emojis
add ignore-optional to yarn config
use yarn to install global gulp-cli package for ci
refactor subrunner to work on arbitrary collections of packages
fix some cwd-induced bugs
only check if peerDependencies satisfy devDependencies, fail if they don't
release all bundles with npm run release-bundles
update docs
Conventional Commits & Changelogs
@lazd lazd removed the blocked See description and comments for what is blocking this issue label Sep 19, 2019
@jianliao jianliao merged commit cb7fd4b into master Sep 19, 2019
@GarthDB GarthDB deleted the lerna branch September 21, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment