Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buttongroup)!: migrate to S2 #2457

Merged
merged 3 commits into from
Feb 2, 2024
Merged

feat(buttongroup)!: migrate to S2 #2457

merged 3 commits into from
Feb 2, 2024

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Jan 22, 2024 •
edited

Description

BREAKING CHANGE

Migrations the button group component to S2

  • updates tokens for vertical and horizontal spacing with in the buttongroup component
  • includes size small with in Chromatic

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • In storybook, buttongroup gap spacing match S2 token updates @mdt2

  • In the docs site, buttongroup gap spacing match S2 token updates @mdt2

  • VRTs now also display a small buttongroup in addition to the default size @mdt2

  • design validation @jenndiaz

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited

File metrics

Summary

Total size: 3.89 MB*
Total change (Δ): ⬇ 25.26 KB (-0.63%)
Table reports on changes to a package's main file. Other changes can be found in the collapsed "Details" below.

Package Size Δ
actiongroup 5.70 KB ⬇ 2.80 KB
buttongroup 1.38 KB ⬇ 0.53 KB
tokens 198.68 KB ⬇ 7.18 KB
Details

actiongroup

File Head Base Δ
index-base.css 5.70 KB 8.02 KB ⬇ 2.32 KB (-28.88%)
index-theme.css 0.59 KB 1.06 KB ⬇ 0.49 KB (-45.30%)
index-vars.css 5.70 KB 8.50 KB ⬇ 2.80 KB (-32.91%)
index.css 5.70 KB 8.50 KB ⬇ 2.80 KB (-32.91%)
mods.json 0.25 KB 0.40 KB ⬇ 0.15 KB (-37.47%)
themes/express.css 0.59 KB 0.89 KB ⬇ 0.30 KB (-33.33%)
themes/spectrum.css 0.59 KB 0.79 KB ⬇ 0.20 KB (-24.91%)

buttongroup

File Head Base Δ
index-base.css 1.38 KB 1.90 KB ⬇ 0.53 KB (-27.32%)
index-vars.css 1.38 KB 1.90 KB ⬇ 0.53 KB (-27.32%)
index.css 1.38 KB 1.90 KB ⬇ 0.53 KB (-27.32%)
mods.json 0.15 KB 0.15 KB -

tokens

File Head Base Δ
css/dark-vars.css 36.30 KB 25.13 KB ⬆ 11.17 KB (44.43%)
css/express/custom-dark-vars.css 0.61 KB 0.61 KB -
css/express/custom-darkest-vars.css 0.61 KB 0.61 KB -
css/express/custom-large-vars.css 0.51 KB 0.51 KB -
css/express/custom-light-vars.css 0.65 KB 0.65 KB -
css/express/custom-medium-vars.css 0.49 KB 0.49 KB -
css/express/custom-vars.css 0.04 KB 0.04 KB -
css/global-vars.css 45.28 KB 39.57 KB ⬆ 5.71 KB (14.43%)
css/large-vars.css 27.90 KB 25.49 KB ⬆ 2.42 KB (9.48%)
css/light-vars.css 36.31 KB 25.13 KB ⬆ 11.18 KB (44.51%)
css/medium-vars.css 27.83 KB 25.42 KB ⬆ 2.41 KB (9.48%)
css/spectrum/custom-dark-vars.css 3.63 KB 3.63 KB -
css/spectrum/custom-darkest-vars.css 3.63 KB 3.63 KB -
css/spectrum/custom-large-vars.css 4.76 KB 4.76 KB -
css/spectrum/custom-light-vars.css 3.63 KB 3.63 KB -
css/spectrum/custom-medium-vars.css 5.00 KB 5.00 KB -
css/spectrum/custom-vars.css 2.10 KB 2.10 KB -
index.css 198.68 KB 205.86 KB ⬇ 7.18 KB (-3.49%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited

🚀 Deployed on https://pr-2457--spectrum-css.netlify.app

@jenndiaz jenndiaz marked this pull request as ready for review January 23, 2024 00:01
mdt2
mdt2 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Aligns with the spec tokens. Thanks for adding the Chromatic coverage for small 🎉

jawinn
jawinn approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@jawinn jawinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested the Chromatic template as well.

components/buttongroup/index.css Outdated
Comment on lines 14 to 16
.spectrum-ButtonGroup--sizeM,
.spectrum-ButtonGroup--sizeL,
.spectrum-ButtonGroup--sizeXL {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove these three classes, since only small is different than the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I've removed them and updated our docs and migration guide to reflect them being removed.

@jenndiaz jenndiaz force-pushed the jenndiaz/s2-migrate-buttongroup branch 2 times, most recently from cffb36c to cf1d6fe Compare January 24, 2024 17:58
@jenndiaz jenndiaz added ask design Questions or topics for the design team ready-for-review labels Jan 29, 2024
@pfulton pfulton added the S2 Spectrum 2 label Jan 29, 2024
@jenndiaz jenndiaz added design-approved and removed ask design Questions or topics for the design team labels Jan 31, 2024
@pfulton pfulton added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Feb 2, 2024
@pfulton pfulton force-pushed the jenndiaz/s2-migrate-buttongroup branch from cf1d6fe to 5519aa5 Compare February 2, 2024 16:50
@pfulton pfulton merged commit 79b8681 into spectrum-two Feb 2, 2024
10 checks passed
@pfulton pfulton deleted the jenndiaz/s2-migrate-buttongroup branch February 2, 2024 17:07
pfulton pushed a commit that referenced this pull request Feb 2, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
2298170 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Feb 5, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
66d2cee 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Feb 22, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
40eb9f3 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Feb 26, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
38c49db 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Mar 11, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
bbcb2a3 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Mar 19, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
621da05 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Mar 28, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
a2c7fe6 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Mar 28, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
f28acc5 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 1, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
7f73266 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 1, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
8c6c67f 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 3, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
9b3daf1 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 4, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
f905916 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 5, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
ea93f3c 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 11, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
5861947 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 11, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
96114ef 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Apr 12, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
d26ec22 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Apr 15, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
4a1be5b 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 18, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
b271115 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Apr 19, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
b1d5eff 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request Apr 19, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
68afe6e 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 26, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
6728ab8 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 26, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
04ee0b4 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 26, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
5f01f6c 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 26, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
10de7ab 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 26, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
e13442b 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
castastrophe pushed a commit that referenced this pull request Apr 30, 2024
@jenndiaz @castastrophe
feat(buttongroup)!: migrate to S2 (#2457)
df9ea6a 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request May 1, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
d86f546 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request May 3, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
a46c4a8 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
rise-erpelding pushed a commit that referenced this pull request May 7, 2024
@jenndiaz @rise-erpelding
feat(buttongroup)!: migrate to S2 (#2457)
455e51b 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
pfulton pushed a commit that referenced this pull request May 10, 2024
@jenndiaz @pfulton
feat(buttongroup)!: migrate to S2 (#2457)
40f91fc 
BREAKING CHANGE: migrates Button Group to Spectrum 2

Also:
* docs(buttongroup): expand chromatic coverage
* refactor(buttongroup): remove extra css classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdt2 mdt2 mdt2 approved these changes

@pfulton pfulton pfulton approved these changes

@jawinn jawinn jawinn approved these changes

Assignees
No one assigned
Labels
design-approved ready-for-review S2 Spectrum 2 skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jenndiaz @pfulton @jawinn @mdt2