-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade to yarn 4.1.1 #2546
Conversation
90c5a1e
to
982d30d
Compare
🚀 Deployed on https://pr-2546--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.57 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
981a6c0
to
133a86b
Compare
133a86b
to
f6fab30
Compare
f6fab30
to
3ea5e8b
Compare
76bf242
to
2ff0c7c
Compare
6dc25b9
to
175e783
Compare
165c641
to
43e9b3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me after the addition of node-gyp to the dependencies ✨
43e9b3b
to
fc90849
Compare
fc90849
to
bbe7de4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be working well for me, no issues!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! These steps all appear to be working. After it built successfully, I clicked through a bunch of components in the docs and in Storybook and did not see anything off.
One thing I wanted to note were a few of the warnings after yarn install
. These might be worth some followup work. The prettier
version caught my attention.
Yes I noticed the prettier warning too. The others are expected due to how we're supporting deprecated components in storybook and some tools require types even if you don't use typescript. I think we should downgrade the eslint prettier plugin though in a separate PR and that should correct the issue we're seeing. We might also be able to update prettier soon if we transition to changesets because lerna is our prettier blocker at the moment. |
bbe7de4
to
5c74b7c
Compare
5c74b7c
to
c71ef5f
Compare
* refactor(searchwithin): deprecate component * chore: missing deprecated dependencies in dev build --------- Co-authored-by: castastrophe <castastrophe@users.noreply.github.com>
c71ef5f
to
a907e70
Compare
Description
Why upgrade from yarn 1.x (aka classic)?
My reasons for support an upgrade to Yarn Modern is it's tooling around monorepo management (see constraints, versioning, interactive upgrades, and a strong set of command-line tools).
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Setting up your environment:
corepack enable
more detailed instructionsnvm use
to ensure you are using the right version of nodeyarn install
- expect the output formatting to be quite colorful compared with yarn 1Regression testing
Validate:
yarn install
yarn build
yarn dev
yarn start
To-do list