Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove abstractions from build process for grid and keyframe #2842

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Jun 13, 2024

Description

Set reduceIdents to false for cssnano minification as the grid-template-area and keyframe magnifications were causing mismatches in the resulting code.

How and where has this been tested?

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:

The pages render correctly, are accessible, and are responsive.

  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe added bug Results from a bug in the CSS implementation size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. run_vrt For use on PRs looking to kick off VRT ready-for-review labels Jun 13, 2024
@castastrophe castastrophe self-assigned this Jun 13, 2024
Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 04f2cbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@spectrum-css/coachindicator Patch
@spectrum-css/dialog Patch
@spectrum-css/menu Patch
@spectrum-css/progressbar Patch
@spectrum-css/progresscircle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 13, 2024

File metrics

Summary

Total size: 4.66 MB*
Total change (Δ): ⬆ 7.52 KB (0.16%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
coachindicator 7.85 KB ⬆ 0.03 KB
dialog 14.80 KB ⬆ 1.62 KB
menu 41.45 KB ⬆ 0.66 KB
progressbar 11.02 KB ⬆ 0.08 KB
progresscircle 11.04 KB ⬆ 0.14 KB

Details

coachindicator

File Head Base Δ
index-base.css 7.85 KB 7.82 KB ⬆ 0.03 KB (0.35%)
index-vars.css 7.85 KB 7.82 KB ⬆ 0.03 KB (0.35%)
index.css 7.85 KB 7.82 KB ⬆ 0.03 KB (0.35%)
metadata.json 3.09 KB 3.09 KB -

dialog

File Head Base Δ
index-base.css 14.80 KB 13.18 KB ⬆ 1.62 KB (12.30%)
index-vars.css 14.80 KB 13.18 KB ⬆ 1.62 KB (12.30%)
index.css 14.80 KB 13.18 KB ⬆ 1.62 KB (12.30%)
metadata.json 5.66 KB 5.66 KB -

menu

File Head Base Δ
index-base.css 41.45 KB 40.80 KB ⬆ 0.66 KB (1.58%)
index-vars.css 41.45 KB 40.80 KB ⬆ 0.66 KB (1.58%)
index.css 41.45 KB 40.80 KB ⬆ 0.66 KB (1.58%)
metadata.json 18.76 KB 18.76 KB -

progressbar

File Head Base Δ
index-base.css 11.02 KB 10.93 KB ⬆ 0.08 KB (0.75%)
index-vars.css 11.02 KB 10.93 KB ⬆ 0.08 KB (0.75%)
index.css 11.02 KB 10.93 KB ⬆ 0.08 KB (0.75%)
metadata.json 5.93 KB 5.93 KB -

progresscircle

File Head Base Δ
index-base.css 11.04 KB 10.91 KB ⬆ 0.14 KB (1.21%)
index-vars.css 11.04 KB 10.91 KB ⬆ 0.14 KB (1.21%)
index.css 11.04 KB 10.91 KB ⬆ 0.14 KB (1.21%)
metadata.json 3.26 KB 3.26 KB -
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Jun 13, 2024

🚀 Deployed on https://pr-2842--spectrum-css.netlify.app

@castastrophe castastrophe merged commit 4cd3a15 into main Jun 13, 2024
12 checks passed
@castastrophe castastrophe deleted the fix-cssnano-reduce-idents branch June 13, 2024 18:10
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Results from a bug in the CSS implementation ready-for-review run_vrt For use on PRs looking to kick off VRT size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants