docs(swatch,swatchgroup,table,tabs): docs migrations to storybook #2925
+2,597
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 Deployed on https://pr-2925--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.63 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
9 tasks
marissahuysentruyt
force-pushed
the
marissahuysentruyt/css-793-docs-to-storybook-pt2
branch
2 times, most recently
from
597c65b
to
6b6d58a
Compare
15 tasks
marissahuysentruyt
added
wip
marissahuysentruyt
force-pushed
the
marissahuysentruyt/css-793-docs-to-storybook-pt2
branch
from
f7ce386
to
8633c48
Compare
marissahuysentruyt
added
size-2 S
- templates for sizes, border, rectangle, disabled, image, gradient, corner rounding, nothing/empty
- templates for sizes, corner rounding
- templates for sizes, body dropzone, hasColumnDividers
- templates for sizes, overflow, densities, orientations, quiet - moves markup to template.js
- corrects the misuse of `is-image` in favor of `spectrum-Swatch-image` - correctly adds `is-image` when the swatch represents mixed values
- expand chromatic coverage for new stories - corrects some isDisabled behavior so the disabled state takes precendence over other args (like image, gradient, etc)
marissahuysentruyt
force-pushed
the
marissahuysentruyt/css-793-docs-to-storybook-pt2
branch
from
8633c48
to
c6f7deb
Compare
for new stories, disabled the snapshot since the default group should encompass all stories
marissahuysentruyt
requested review from
jawinn,
castastrophe,
rise-erpelding and
pfulton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues migrating documentation from the static docs site into Storybook. The focus is on
swatch,swatchgroup,tableandtabs. All variants of the components should now be displayed on the StorybookDocspage. All components haveautodocsand/or!devstories now. Migration notes fortablesandtabshave been added to the correspondingchangelogs.Jira
No MDX pages were added for any components.
This PR doesn't need a changeset since it's docs-only.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list