fix(tags): performed the suggested changes

adobe · Aug 18, 2023 · 6e3ef36 · 6e3ef36
1 parent 196bdae
commit 6e3ef36
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/tags/src/Tags.ts b/packages/tags/src/Tags.ts
@@ -70,6 +70,7 @@ export class Tags extends FocusVisiblePolyfillMixin(SpectrumElement) {
     private handleKeydown = (event: KeyboardEvent): void => {
         const { code } = event;
         if (code !== 'PageUp' && code !== 'PageDown') return;
+
         const circularIndexedElement = <T extends HTMLElement>(
             list: T[],
             index: number

diff --git a/tools/reactive-controllers/src/FocusGroup.ts b/tools/reactive-controllers/src/FocusGroup.ts
@@ -130,7 +130,7 @@ export class FocusGroupController<T extends HTMLElement>
                 subtree: true,
             },
             callback: () => {
-                this.changeDefaultItemFocus();
+                this.handleItemMutation();
             },
         });
         this.host = host;
@@ -155,12 +155,9 @@ export class FocusGroupController<T extends HTMLElement>
         );
     }
 
-    changeDefaultItemFocus(): void {
+    handleItemMutation(): void {
         this.clearElementCache();
-        let diff = 0;
-        if (this.currentIndex === this.elements.length) {
-            diff = -1;
-        }
+        const diff = this.currentIndex === this.elements.length ? -1 : 0;
         this.setCurrentIndexCircularly(diff);
         let steps = this.elements.length;
         while (