Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][a11y]: ColorLoupe svg should be hidden from screen readers #3316

Closed
1 task done
majornista opened this issue Jun 13, 2023 · 0 comments · Fixed by #3318
Closed
1 task done

[Bug][a11y]: ColorLoupe svg should be hidden from screen readers #3316

majornista opened this issue Jun 13, 2023 · 0 comments · Fixed by #3318
Labels
bug Something isn't working Component: Color Loupe triage An issue needing triage

Comments

@majornista
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

ColorLoupe

Expected behavior

ColorLoupe should be hidden from screen readers.

Actual behavior

Interacting with ColorArea using VoiceOver will sometime navigate to the svg image used within the ColorLoupe.

Screenshots

No response

What browsers are you seeing the problem in?

Chrome, Safari

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response
@majornista majornista added bug Something isn't working Component: Color Loupe triage An issue needing triage labels Jun 13, 2023
@majornista majornista changed the title [Bug][a11y]: ColorLoupe svg should have be hidden from screen readers [Bug][a11y]: ColorLoupe svg should be hidden from screen readers Jun 13, 2023
majornista added a commit that referenced this issue Jun 14, 2023
@majornista
fix(color-loupe): svg should be hidden from screen readers #3316
1a0ba0a
@majornista majornista mentioned this issue Jun 14, 2023
Merged
13 tasks
@majornista majornista linked a pull request Jun 14, 2023 that will close this issue
fix(color-loupe): svg should be hidden from screen readers #3316 #3318
Merged
13 tasks
Westbrook pushed a commit that referenced this issue Jun 26, 2023
@majornista
fix(color-loupe): svg should be hidden from screen readers #3316
9b94a1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Component: Color Loupe triage An issue needing triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(color-loupe): svg should be hidden from screen readers #3316 adobe/spectrum-web-components
1 participant
@majornista