Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): added lit dependency #3489

Merged
merged 1 commit into from Jul 25, 2023
Merged

fix(grid): added lit dependency #3489

merged 1 commit into from Jul 25, 2023

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Jul 25, 2023

Description

Added Lit dependency in Grid Component

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1
    1. Go here
    2. Do this
  • Test case 2
    1. Go here
    2. Do this

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@Rajdeepc Rajdeepc added bug Something isn't working dependencies Pull requests that update a dependency file labels Jul 25, 2023
@Rajdeepc Rajdeepc requested a review from Westbrook July 25, 2023 10:14
@Rajdeepc Rajdeepc marked this pull request as ready for review July 25, 2023 10:14
@Rajdeepc Rajdeepc linked an issue Jul 25, 2023 that may be closed by this pull request
1 task
@github-actions
Copy link

Tachometer results

Chrome

grid permalink

Version Bytes Avg Time vs remote vs branch
npm latest 423 kB 48.50ms - 50.02ms - unsure 🔍
-2% - +2%
-0.79ms - +1.00ms
branch 424 kB 48.68ms - 49.62ms unsure 🔍
-2% - +2%
-1.00ms - +0.79ms
-
Firefox

grid permalink

Version Bytes Avg Time vs remote vs branch
npm latest 423 kB 114.60ms - 129.00ms - unsure 🔍
-7% - +8%
-8.99ms - +9.83ms
branch 424 kB 115.32ms - 127.44ms unsure 🔍
-8% - +7%
-9.83ms - +8.99ms
-

@Westbrook Westbrook changed the title fix(Grid): added lit dependency in grid fix(grid): added lit dependency Jul 25, 2023
Copy link
Collaborator

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Westbrook Westbrook merged commit fb5f166 into main Jul 25, 2023
47 checks passed
@Westbrook Westbrook deleted the bug/lit-grid-dependency branch July 25, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: GridController in @spectrum-web-components/grid missing 'lit' dependency
2 participants