Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Toast does not open in the correct position when used with overlay-trigger #3510

Closed
1 task done
benjamind opened this issue Aug 3, 2023 · 1 comment
Closed
1 task done

[Bug]: Toast does not open in the correct position when used with overlay-trigger #3510

benjamind opened this issue Aug 3, 2023 · 1 comment
Labels
bug Something isn't working triage An issue needing triage

Comments

@benjamind
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

toast

Expected behavior

sp-toast used in an overlay trigger should open in the correct position.

Actual behavior

toast always appears centered on the trigger

Screenshots

No response

What browsers are you seeing the problem in?

Firefox, Chrome, Safari, Microsoft Edge

How can we reproduce this issue?

  1. Create an sp-toast inside an overlay trigger with a specified placement.
  2. Trigger the overlay

Sample code that illustrates the problem

https://studio.webcomponents.dev/edit/lzXQXJSMsytEpRIwIft3/src/index.ts?p=stories

Logs taken while reproducing problem

No response
@benjamind benjamind added bug Something isn't working triage An issue needing triage labels Aug 3, 2023
benjamind added a commit that referenced this issue Aug 3, 2023
@benjamind
fix(toast): switches toast[open] to use visibility hidden to fix over…
92147f6 
…lay handling (#3510)
@benjamind benjamind mentioned this issue Aug 3, 2023
Merged
11 tasks
Westbrook pushed a commit that referenced this issue Aug 7, 2023
@benjamind
fix(toast): switches toast[open] to use visibility hidden to fix over…
8428cad 
…lay handling (#3511)

* fix(toast): switches toast[open] to use visibility hidden to fix overlay handling (#3510)

* fix(toast): switches overlaid story to click rather than hover

* fix(toast): update vrt cache key
@Westbrook
Copy link
Collaborator

Closed by #3511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage An issue needing triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamind @Westbrook