fix(toast): switches toast[open] to use visibility hidden to fix overlay handling #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsChrometoast permalink
Firefoxtoast permalink
|
Westbrook
reviewed
Aug 4, 2023
| ] as [Placement, string][] | ||
| ).map(([placement, variant]) => { | ||
| return html` | ||
| <overlay-trigger |
There was a problem hiding this comment.
We probably should not insinuate that Toast elements can/should be opened on hover. I think if this was set up at type="click" and the slot was slot="click-content" that we'd be pretty good to go here!
There was a problem hiding this comment.
haha yes good point.
There was a problem hiding this comment.
addressed in 592bdbd
Westbrook
reviewed
Aug 5, 2023
There was a problem hiding this comment.
Looks a little unique, but otherwise looks pretty good to go!
If you could cycle the VRTs, we'll be able to merge this and have it out to you sometime next week.
Westbrook
approved these changes
Aug 7, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches
sp-toastto use the same behavior assp-tooltipfor controlling visibility with the[open]attribute. This switches fromdisplay: nonetovisibility:hiddenwhich means the element now has size when hidden allowing the overlay behavior to properly measure it and therefore position it.Related issue(s)
#3510
Motivation and context
Fixes the placement in overlays.
How has this been tested?
Added storybook to cover this case, and tested locally in Chrome.
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.