Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework imported css variables from spectrum-css #56

Closed
benjamind opened this issue Jun 17, 2019 · 2 comments
Closed

Rework imported css variables from spectrum-css #56

benjamind opened this issue Jun 17, 2019 · 2 comments
Assignees

Comments

@benjamind
Copy link
Contributor

Expected Behaviour

Since our CSS is 'modern' and has all the css variables from spectrum intact and not processed out we should be able to include a minimum set of variables for medium/large/light/dark themes.

Actual Behaviour

Currently we include all the CSS produced by spectrum in our themes and this results in a huge amount of wasted bytes.

Reproduce Scenario (including but not limited to)

Load up the documentation site and inspect the imported css.

@benjamind
Copy link
Contributor Author

@cuberoot I took a quick look at this and I think it should be relatively easy to modify the css processing to import the theme files (medium/large, dark/light and global/core) and wrap them in :host, :root selectors so they can be imported into root elements which will then apply styling down the tree. This should massively reduce the CSS payload.

@msdewey
Copy link
Collaborator

msdewey commented Jun 27, 2019

closing issue, resolved by #87

@msdewey msdewey closed this as completed Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants