Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The constructor for Iconset violates custom element requirements #67

Closed
cuberoot opened this issue Jun 19, 2019 · 2 comments
Closed

The constructor for Iconset violates custom element requirements #67

cuberoot opened this issue Jun 19, 2019 · 2 comments
Assignees

Comments

@cuberoot
Copy link
Collaborator

Expected Behaviour

We should be able to create an iconset derivative without errors

Actual Behaviour

Latest Chrome canary is flagging a problem and won't create an iconset because it adds an attribute to itself in the constructor. That violates the spec

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

@benjamind
Copy link
Contributor

I think we can close this now, can you confirm @cuberoot ?

@cuberoot
Copy link
Collaborator Author

cuberoot commented Aug 2, 2019

Yep

@cuberoot cuberoot closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants