Fix iconset to not set attribute in constructor #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix code that violates the requirements for custom element constructors (see spec: https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-conformance). Chrome was flagging this as a problem in LrWeb.
benjamind
suggested changes
Jun 19, 2019
benjamind
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix code that violates the requirements for custom element constructors (see spec).
Chrome was flagging this as a problem in LrWeb.
Related Issue
#67
Motivation and Context
This issue is causing iconsets to not work in my project in Chrome Canary
How Has This Been Tested?
All tests pass and I checked that the iconsets were loading in the Storybook stories
Screenshots (if appropriate):
Types of changes
Checklist: