fix(slider): slider input aria-valuetext omits formatOptions for unit #3340

[majornista]

Description

Related issue(s)

• [Bug][a11y]: Slider input aria-valuetext omits formatOptions for unit #3340

Motivation and context

The aria-valuetext attribute on the input[type="range"] element within the SliderHandle in the Slider shadowDom should include the _forcedUnit for units not included in Intl.NumberFormatOptions, like px or pc.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch Preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Classic | Lightest | Medium | LTR
• Classic | Lightest | Medium | RTL
• Classic | Lightest | Large | LTR
• Classic | Lightest | Large | RTL
• Classic | Light | Medium | LTR
• Classic | Light | Medium | RTL
• Classic | Light | Large | LTR
• Classic | Light | Large | RTL
• Classic | Dark | Medium | LTR
• Classic | Dark | Medium | RTL
• Classic | Dark | Large | LTR
• Classic | Dark | Large | RTL
• Classic | Darkest | Medium | LTR
• Classic | Darkest | Medium | RTL
• Classic | Darkest | Large | LTR
• Classic | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL

[github-actions]

Tachometer results

Chrome

slider permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	448 kB	144.32ms - 148.17ms	-	unsure 🔍 -0% - +4% -0.31ms - +5.15ms
branch	447 kB	141.89ms - 145.76ms	unsure 🔍 -4% - +0% -5.15ms - +0.31ms	-

Firefox

slider permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	448 kB	424.24ms - 447.80ms	-	unsure 🔍 -4% - +2% -18.86ms - +10.82ms
branch	447 kB	431.01ms - 449.07ms	unsure 🔍 -3% - +4% -10.82ms - +18.86ms	-

[Westbrook]

LGTM. Just rebased to main, and will merge this up if all stays green. Thanks @majornista 🙇🏼