docs(action-menu): include action menu label in stories and READMEs #4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalink
action-menu permalink
card permalink
coachmark permalink
combobox permalink
menu permalink
overlay permalink
picker permalink
popover permalink
slider permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-menu permalink
card permalink
coachmark permalink
combobox permalink
menu permalink
overlay permalink
picker permalink
popover permalink
slider permalink
split-button permalink
tooltip permalink
|
Westbrook
changed the title
Westbrook
approved these changes
Mar 5, 2024
13 tasks
Westbrook
pushed a commit
that referenced
this pull request
Mar 15, 2024
…4158) * chore(action-menu): include action menu label in stories and READMEs (#4127) * docs(dropzone): demonstrate how to announce items added to dropzone * docs(dropzone): add upload button in example * docs(dropzone): address typos * docs(dropzone): address feedback * docs(dropzone): improve wording in dropzone story * chore(dropzone): updated golden image cache * chore(dropzone): updated golden image cache --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@rajdeeps-mbp-2.macromedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated SWC component READMEs and stories that include the action menu as part of examples with an expected action menu label to demonstrate accessible examples aligning with existing SWC action menu documentation:
Related issue(s)
Motivation and context
Provides consumers of SWC with accessible usage examples of the Action Menu across different SWC components such as the Card and Overlay.
How has this been tested?
yarn storybook)Screenshots (if appropriate)
Before:
Screen.Recording.2024-03-05.at.11.15.36.AM.mov
After:
Screen.Recording.2024-03-05.at.11.17.37.AM.mov
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.