fix(slider): skip variant="filled" css when fill-start #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
changed the title
Rajdeepc
changed the title
Rajdeepc
changed the title
1 task
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeslider permalinktest-basic
Firefoxslider permalinktest-basic
|
Westbrook
reviewed
Mar 26, 2024
| @@ -101,7 +101,7 @@ export class Slider extends SizedMixin(ObserveSlotText(SliderHandle, ''), { | |||
| if (variant === this.variant) { | |||
| return; | |||
| } | |||
| if (variants.includes(variant)) { | |||
| if (variants.includes(variant) && this.fillStart === undefined) { | |||
There was a problem hiding this comment.
We'll need text in the readme as to the prioritization here.
added 2 commits
March 27, 2024 14:23
… into bug/slider-variant-filled
Westbrook
approved these changes
Mar 27, 2024
TarunAdobe
pushed a commit
that referenced
this pull request
Apr 1, 2024
* fix(slider): no change in background for variant filled and fill start * chore(slider): updated readme for slider with fill start and variant filled --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a condition
this.fillStart === undefinedto the setvariantmethod in order to address a specific issue. The condition ensures that the variant attribute is only set if the fillStart property is undefined, preventing unintended behavior when both variant andfillStartattributes are present simultaneously.Changes
Added a condition
this.fillStart === undefinedto the set variant method.Updated the logic to set or remove the variant attribute based on the new condition.
Related issue(s)
variant="filled"ANDfill-startfills in unexpected ways. #3973Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.