Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the version of web-component-analyzer #73

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

cuberoot
Copy link
Collaborator

Description

Bump the version of web-component-analyzer that we depend on

Related Issue

#65

Motivation and Context

The newer version extracts other tags that we would like to use like @slot

How Has This Been Tested?

@andrewhatran Tried using the slot tag and it was working

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cuberoot cuberoot requested a review from benjamind June 20, 2019 00:15
Copy link
Contributor

@benjamind benjamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cuberoot cuberoot merged commit 671a43c into master Jun 20, 2019
@Westbrook Westbrook deleted the cuberoot/analyzer-bump branch November 2, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants