fix(overlay): use esm build from popper and point through to types #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
commented
Nov 3, 2020
| @@ -13,17 +13,19 @@ governing permissions and limitations under the License. | |||
| // Bundle only what we want from popper | |||
| // See: https://popper.js.org/docs#popper-lite-tree-shaking | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/triple-slash-reference | |||
| /// <reference path="../local.d.ts" /> | |||
There was a problem hiding this comment.
This is the weirdest part. Even though I could get this to connect via yarn tsc --build packages/overlay/tsconfig.json without this reference, I could never get yarn tsc --build packages/*/tsconfig.json, our standard usage, to work without this... 😞
Westbrook
force-pushed
the
westbrook/popper
branch
from
1200516
to
b79cf6a
Compare
Westbrook
force-pushed
the
westbrook/popper
branch
from
b79cf6a
to
866c10f
Compare
Westbrook
force-pushed
the
westbrook/popper
branch
from
866c10f
to
b2e3e64
Compare
Westbrook
force-pushed
the
westbrook/popper
branch
from
b2e3e64
to
50ad768
Compare
cuberoot
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to the ESM build from Popper so as to remove the need to
process.envworkarounds in no build contexts.I wish that floating-ui/floating-ui#1188 and floating-ui/floating-ui#1188 and floating-ui/floating-ui#933 would have gotten us a better solution. Needing to use an off main entry point build while hand managing the connectivity to the types is not my favorite thing in the world.
Related Issue
refs 963
Motivation and Context
process.envshould be removed from production facing code.How Has This Been Tested?
Works locally and in CI
Types of changes
Checklist: