TNT-41046 Encapsulate telemetry reporting to make it easy to switch storage layer #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyruwruw
commented
Jun 2, 2021
andyruwruw
commented
Jun 2, 2021
andyruwruw
commented
Jun 2, 2021
andyruwruw
commented
Jun 2, 2021
andyruwruw
commented
Jun 2, 2021
andyruwruw
commented
Jun 2, 2021
andyruwruw
commented
Jun 2, 2021
dcottingham
reviewed
Jun 3, 2021
|
Added the edits! |
dcottingham
reviewed
Jun 4, 2021
| @@ -28,22 +27,12 @@ describe("TelemetryProvider", () => { | |||
| } | |||
| }) | |||
| ); | |||
| expect(mockExecute.mock.calls[0][1][0].execution).toBe(1); | |||
There was a problem hiding this comment.
Minor nitpick for sake of consistency - let's remove this line and add it into the previous assertion:
expect.objectContaining({........, execution: 1 })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Telemetry related logic was moved out of the target-decisioning-engine notificationProvider and into target-tools telemetryProvider.
The TelemetryProvider stores telemetry entries, and can add them to a DeliveryRequest.
Currently the implementation was kept relatively the same. The NotificationProvider has a TelemetryProvider, using it to store entries, and to add telemetries before sending notifications.
Related Issue
Jira Ticket
Motivation and Context
Description from Jira Ticket:
Currently telemetry reporting is done through Delivery API and makes its way into Prometheus; reporting and storage are tightly coupled in the SDKs. We should decouple them and create an abstract storage service in case we switch to a different storage layer in the future.
How Has This Been Tested?
Tests were added for the new Telemetry Provider, just ensuring it stores entries and adds them to a request.
Tests were run with
npm run testand written using jest.This implementation will impact how the notification provider stores telemetry entries by encapsulating telemetry related logic in a separate class.
Types of changes
Checklist: