Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJM-33819 Rename eventtype Deliver to Send and add Dismiss #1619

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

surbhi114
Copy link
Contributor

Please link to the issue:
Jira:https://jira.corp.adobe.com/browse/CJM-33819
Github Issue: #1519

Summary:
Rename eventtype decisioning.propositionDeliver to decisioning.propositionSend and adds decisioning.propositionDismiss

Copy link

@donwalling donwalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mjasrotia
Copy link
Collaborator

Was this a recently introduced event type ? I am wondering if there are any existing segments created based on this event type which will no longer evaluate if we change this. Could you please confirm before we can make this change ?

@donwalling
Copy link

hi @mjasrotia yes, Deliver was recently introduced and is now being changed to Send. It is only being used in Stage environment right now, and will be changed once the xdm change is available. This feature is still pre-release, and the name change is needed so that we can progress to beta.

@mjasrotia mjasrotia merged commit 60719b9 into adobe:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants