Add selection strategy id to ODE DecisionEvent schema #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guayang-adobe
approved these changes
Dec 12, 2022
ngalala-adobe
approved these changes
Dec 12, 2022
|
@mjasrotia @cmathis could you please help review this PR? thanks! |
jwen-adobe
reviewed
Dec 13, 2022
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Please add the required field "xdm:id" in the example.
There was a problem hiding this comment.
thanks! I refactored the PR to add strategy-detail schema and add strategy id using the new schema.
jaszhang-adobe
force-pushed
the
selectionStrategy
branch
from
576df1c
to
0bd8ba2
Compare
jaszhang-adobe
force-pushed
the
selectionStrategy
branch
from
0bd8ba2
to
e74e9c4
Compare
guayang-adobe
approved these changes
Dec 15, 2022
jwen-adobe
approved these changes
Dec 15, 2022
jaszhang-adobe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please link to the issue #1653
Add selection strategy id to propositionDetails.activity which uses activity-detail schema.Update: activity id is required field but it may cause confusion if we populate selection strategy id to activity id.Add strategy schema and use it to add selectionStrategy field in proposition-detail schema.
Reviewers: @ngalala-adobe @guayang-adobe