Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mwpw 136871 #2154

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Mwpw 136871 #2154

merged 6 commits into from
Apr 17, 2024

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Apr 16, 2024

TwP Card Milo block logic

@Axelcureno Axelcureno requested a review from a team as a code owner April 16, 2024 20:10
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@yesil yesil merged commit dc7e023 into adobecom:twp Apr 17, 2024
9 of 16 checks passed
yesil pushed a commit to yesil/milo that referenced this pull request Apr 17, 2024
* MWPW-136871: TwP Merch Card

* unit tests

* twp card

* price display in TwP

* deps update
milo-pr-merge bot pushed a commit that referenced this pull request Jun 17, 2024
* Mwpw-136871: TwP merch card (#2088)

* MWPW-136871: TwP Merch Card

* unit tests

* TWP block draft (#2105)

* add draft for a merch-twp block

---------

Co-authored-by: Axel Cureno Basurto <axel@adobe.com>

* Mwpw 136871: Price display inside TwP merch card (#2110)

* MWPW-136871: TwP Merch Card

* unit tests

* twp card

* price display in TwP

* deps update

* Mwpw 136871 (#2154)

* MWPW-136871: TwP Merch Card

* unit tests

* twp card

* price display in TwP

* deps update

* MWPW-138927: merch-twp WIP (#2160)

Merging proactively for a GWP demo.

* MWPW-138927: desktop step 2 layout WIP

* remove comment

* pr feedback

* update deps

* update deps

* update deps

* update deps

* fixed tests

* fix lagging subscription panel

* WIP

* fix tests

* fix tests

* wip

* fix failing test

* fix failing tests

* remove files

* improve code coverage

* address first batch of comments

* fix dependencies

* fix unit tests

* add missing test cases

---------

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Axel Cureno Basurto <axel@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants