MWPW-138927: merch-twp WIP #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add typography classes to ul and ol, remove redundant :scope * update variable name
decorate splits in separate func, bail if video, fix styling
* MWPW-142643 update quantity-selector libs * MWPW-142643 update merch-cards.js * MWPW-142643 quantity selector size and rules for TWP and D2P --------- Co-authored-by: Volodymyr Kniaziev <vkniaziev@adobe.com>
…new.digitalData in the alloy call (adobecom#1998) * Add support for bold as header if no header * Add tracking to modal close button * separate branches * include the word modal in analytic * Changing name to match old analytic and removing old * unit test update to new name * conflict resolved
…on Tags (adobecom#2065) add new entitlements
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
* MWPW-145728 Increase timeout; add metadata support * Remove duplicate code from bad merge * Add analytics calculations * move eventListener, add analytics * add prefix to analytic * consolidate AA call, add lana call * swap true and false --------- Co-authored-by: vgoodric <vgoodric@adobe.com>
…obecom#2104) * update depracated delete methods * update tests for api deps
Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com> Co-authored-by: Honwai Wong <honstar.wong@gmail.com>
MWPW-143071 added new copy Co-authored-by: Volodymyr Kniaziev <vkniaziev@adobe.com> Co-authored-by: Narcis Radu <github@narcisradu.ro>
added xl-size class for dialog-modal
* Add practice timeline and add text to mep * Remove practice blocks * Add timeline * Remove default colors * Update sibling text class * update getColWidth * Add neg spacing * Remove neg-space feature * Remove old max-width * Fix width and remove neg-spacing css * Update column width * Add reversed variant and cleanup * Add basic dir=rtl support * Use grid margins width outside of modal * Remove left right padding * Fix folder name
…2112) Revert "MWPW-144813: Add 'xl-size' class for dialog-modal (adobecom#2048)" This reverts commit b2c9720.
…dobecom#2114) Revert "Revert "MWPW-144813: Add 'xl-size' class for dialog-modal" (adobecom#2112)" This reverts commit 9fff397.
* Update Kodiak config.yaml Change default assignee to Silviu per Narcis. Also adds documentation in the file. * Remove jed
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
…is chosen (adobecom#2085) [MILO][MEP] Pzn analytic not added if default experience is chosen
* active element a11y fix * unit test for active element attributes --------- Co-authored-by: Honwai Wong <honstar.wong@gmail.com> Co-authored-by: Narcis Radu <github@narcisradu.ro>
BIgger default padding
* branch banner * fetch key from json base on product authored * remove row content * fetch key file from content root * rename mapping file * convert product to lowercase * refactor * rename app banner block * lint and remove comments * block name update * incorporate review comment * incorporate review comments --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* MWPW-145148 Inline tree.js into fragment.js No code change, just a move of code in tree.js into fragment.js * Move tree test
* MWPW-144254 [merch-card] per type heading map * optional chaining
|
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
3ch023
removed request for
a team,
narcis-radu,
Brandon32,
auniverseaway,
ryanmparrish,
rgclayton,
fullcolorcoder,
Sartxi,
overmyheadandbody,
JasonHowellSlavin,
meganthecoder,
mokimo and
seanchoi-dev
|
FYI @yesil I removed the gigantic list of reviewers since this PR is for now internal (our WIP) |
|
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Mwpw-136871: TwP merch card (#2088) * MWPW-136871: TwP Merch Card * unit tests * TWP block draft (#2105) * add draft for a merch-twp block --------- Co-authored-by: Axel Cureno Basurto <axel@adobe.com> * Mwpw 136871: Price display inside TwP merch card (#2110) * MWPW-136871: TwP Merch Card * unit tests * twp card * price display in TwP * deps update * Mwpw 136871 (#2154) * MWPW-136871: TwP Merch Card * unit tests * twp card * price display in TwP * deps update * MWPW-138927: merch-twp WIP (#2160) Merging proactively for a GWP demo. * MWPW-138927: desktop step 2 layout WIP * remove comment * pr feedback * update deps * update deps * update deps * update deps * fixed tests * fix lagging subscription panel * WIP * fix tests * fix tests * wip * fix failing test * fix failing tests * remove files * improve code coverage * address first batch of comments * fix dependencies * fix unit tests * add missing test cases --------- Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Axel Cureno Basurto <axel@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for the TWP feature branch
preview: https://mwpw-138927--milo--yesil.hlx.page/drafts/ilyas/twp/illustrator#twpmodal
also contains latest stage changes.
Resolves: MWPW-138927