Update download_vpfiles() and select_vpfiles()

[peterdesmet]

For both functions

• Drop country argument and use 5 letter radar codes. Parameter radar renamed to radars. Fixes Use 5 letter radar codes and drop "country" argument in download_vpfiles() and select_vpfiles() #173 👌
• Raise error if radar code is not 5 letters
• Gets rid of RCurl and lubridate. Fixes reduce number of dependencies (if possible) #131 👌
• Update function documentation
• Update function deprecation

download_vpfiles()

Updated syntax:

download_vpfiles(
  date_min = "2016-10-03", # required
  date_max = "2016-10-05", # required
  radars = c("bejab", "bewid"), # required
  directory = "my_data" # optional, default: "."
  overwrite = TRUE # optional, default: FALSE
)

• Unzip to 5 letter radar code directory. Fixes Don't unzip files with download_vpfiles() #172 (comment) 👌

• Add new optional parameter overwrite = FALSE (default) to skip downloading previously downloaded files 🎉

• Just use curl, not httr. Fixes Use httr instead of (r)curl #150 👌

• Simplify path, url, file name creation in function

• Nicer messaging of download status, using message() not print() so they can be ignored in Rmd 🎉

  bewid201710.zip: already downloaded
  bejab201711.zip: http error 404
  bewid201711.zip: successfully downloaded
  

select_vpfiles()

Updated syntax:

select_vpfiles(
  date_min = "2016-10-03", # optional
  date_max = "2016-10-05", # optional
  radars = c("bejab", "bewid"), # optional
  directory = "my_data" # optional, default "." and moved to last position to align with download_vpfiles()
)

• Prepend directory to returned paths, making these directly readable with read_vpfiles(). Fixes select_vpfiles: add data dir to file paths #153 👌
• Make date_min and date_max optional parameters (will only be used if both are set)

[stijnvanhoey]

Nice work. As we will have to do it anyway, please provide unit tests directly when refactoring/adding funcitons. If you need any help writing the tests, just let me know.

[peterdesmet]

As we will have to do it anyway, please provide unit tests directly when refactoring/adding funcitons. If you need any help writing the tests, just let me know.

I agree completely, but have never done this so I would need a crash course from you. 😁 To cover:

• start_date - end_date bug in vp_download #63: start day > end day
• Update download_vpfiles() and select_vpfiles() #176 (comment): character vs character vector

[adokter]

I agree completely, but have never done this so I would need a crash course from you. 😁

Same here!

[stijnvanhoey]

Nice work @peterdesmet