Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add height quantile option to integrate_profile() #485

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Conversation

adokter
Copy link
Owner

@adokter adokter commented Dec 14, 2021

Adds an argument height_quantile to integrate_profile(), which allows calculation of specific height quantiles for the height data column of the output vpi object. height_quantile should have a value between 0-1, with 0=0% percentile closest to the ground, 1=100% percentile furthest from the ground). The default height_quantile=NA continues to output the mean height. height_quantile=0.5 gives the median height.

@adokter adokter self-assigned this Dec 14, 2021
@adokter adokter added this to the 0.6.0 milestone Dec 14, 2021
@adokter
Copy link
Owner Author

adokter commented Dec 14, 2021

Hi @peterdesmet, no need to review this if you are short on time

I keep running into issues with the snaps in _snaps - my machine wants to update them, but I have to revert to the old ones in order to pass the unit tests on github. Any idea why this happens?

@codecov-commenter
Copy link

Codecov Report

Merging #485 (f0cf26e) into master (c901cab) will decrease coverage by 0.27%.
The diff coverage is 34.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   57.62%   57.34%   -0.28%     
==========================================
  Files          55       55              
  Lines        3094     3130      +36     
==========================================
+ Hits         1783     1795      +12     
- Misses       1311     1335      +24     
Impacted Files Coverage Δ
R/integrate_profile.R 72.45% <34.14%> (-10.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c901cab...f0cf26e. Read the comment docs.

@adokter adokter merged commit 85b4f6f into master Dec 16, 2021
@adokter adokter deleted the quantile_height branch December 16, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants