Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-65309 Ratings #267

Closed
wants to merge 1 commit into from
Closed

LPS-65309 Ratings #267

wants to merge 1 commit into from

Commits on Apr 26, 2016

  1. LPS-65309 Round the number. If there is one blog entry that was rated… 

    … in 6.2.x with 4 stars, that will have a normalized value of 0.8 in Liferay 7.0. With the current logic, when it casts 0.8 to int it will cast it to 0. Therefore, it will say that there are 0 positive votes and 1 negative vote, while it should be 1 positive vote (3 or more stars) and 0 negative votes. The other issue is that if you rate something with 1 stars out of 5, with thumbs it should be negative thumb but it was marked as positive because the check was done based on if it's bigger than 0 or equals to 0 but we should check with smaller or bigger than 0.5
    Sergio Gonzalez committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    b606629 View commit details
    Browse the repository at this point in the history