Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-65309 Ratings #267

Closed
wants to merge 1 commit into from
Closed

LPS-65309 Ratings #267

wants to merge 1 commit into from

Conversation

sergiogonzalez
Copy link

No description provided.

LPS-65309 Round the number. If there is one blog entry that was rated…
b606629 
… in 6.2.x with 4 stars, that will have a normalized value of 0.8 in Liferay 7.0. With the current logic, when it casts 0.8 to int it will cast it to 0. Therefore, it will say that there are 0 positive votes and 1 negative vote, while it should be 1 positive vote (3 or more stars) and 0 negative votes. The other issue is that if you rate something with 1 stars out of 5, with thumbs it should be negative thumb but it was marked as positive because the check was done based on if it's bigger than 0 or equals to 0 but we should check with smaller or bigger than 0.5
@sergiogonzalez sergiogonzalez changed the title LPS-65309 Round the number. If there is one blog entry that was rated in 6.2.x with 4 stars, that will have a normalized value of 0.8 in Liferay 7.0. With the current logic, when it casts 0.8 to int it will cast it to 0. Therefore, it will say that there are 0 positive votes and 1 negative vote, while it should be 1 positive vote (3 or more stars) and 0 negative votes. The other issue is that if you rate something with 1 stars out of 5, with thumbs it should be negative thumb but it was marked as positive because the check was done based on if it's bigger than 0 or equals to 0 but we should check with smaller or bigger than 0.5 LPS-65309 Ratings Apr 26, 2016
@adolfopa
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@adolfopa
Copy link
Owner

Pull request submitted to brianchandotcom#39119.

:octocat: Sent from GH.

@adolfopa adolfopa closed this Apr 26, 2016
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 50 minutes 18 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 78867d4c860531fa4c96c62e9ca8e360190f474f

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    41 Jobs Passed.
    2 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-wildfly10-mariadb100-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #4422
           [exec] �[0m�[0m16:34:01,367 INFO  [org.jboss.as.server] (DeploymentScanner-threads - 2) WFLYSRV0009: Undeployed "ROOT.war" (runtime-name: "ROOT.war")
     [exec] �[0m�[0m16:34:01,368 INFO  [org.jboss.as.controller] (DeploymentScanner-threads - 2) WFLYCTL0183: Service status report
     [exec] WFLYCTL0184:    New missing/unsatisfied dependencies:
     [exec]       service jboss.module.service."deployment.ROOT.war".main (missing) dependents: [service jboss.deployment.unit."ROOT.war".FIRST_MODULE_USE] 
     [exec] WFLYCTL0186:   Services which failed to start:      service jboss.module.service."deployment.ROOT.war".main
     [exec] 
     [exec] �[0m�[0m16:34:05,787 INFO  [org.jboss.as.server.deployment.scanner] (DeploymentScanner-threads - 2) WFLYDS0004: Found ROOT.war in deployment directory. To trigger deployment create a file called ROOT.war.dodeploy
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:233: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:542: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:26: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-wildfly.xml:32: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:7671: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2697: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2785: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3176: No server is available at http://localhost:8080/web/guest
      [get] Getting: http://test-1-14/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/4422//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160426094839491.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160426094839491.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiogonzalez @adolfopa @liferay-continuous-integration