Merge branch 'release/5.0.8'

CHANGELOG.md

@@ -1,3 +1,14 @@
+<a name="5.0.8"></a>
+## [5.0.8](https://github.com/adonisjs/ace/compare/v5.0.7...v5.0.8) (2018-10-01)
+
+
+### Bug Fixes
+
+* **command:** disable kluer when no ansi is true ([6ec44e8](https://github.com/adonisjs/ace/commit/6ec44e8))
+* **command:** properly handle no-ansi flag ([3b68504](https://github.com/adonisjs/ace/commit/3b68504))
+
+
+
 <a name="5.0.7"></a>
 ## [5.0.7](https://github.com/adonisjs/ace/compare/v5.0.6...v5.0.7) (2018-10-01)
 

examples/index.js

@@ -27,7 +27,6 @@ kernel.command(
   'greet {name?: Enter the name of the person you want to greet} { --is-admin }',
   'Greet a user',
   async function () {
-
     /**
      * Ask name
      */

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adonisjs/ace",
-  "version": "5.0.7",
+  "version": "5.0.8",
   "description": "Ace is a command line tool for adonisjs framework",
   "main": "index.js",
   "directories": {
@@ -14,7 +14,6 @@
   "scripts": {
     "mrm": "mrm --preset=@adonisjs/mrm-preset",
     "pretest": "npm run lint",
-    "posttest": "npm run coverage",
     "test:local": "FORCE_COLOR=true node bin/index.js --local",
     "test": "nyc node japaFile.js",
     "test:win": "node ./node_modules/japa-cli/index.js",

src/Command/index.js

@@ -44,10 +44,7 @@ const defaults = {
 class Command {
   constructor () {
     this.chalk = kleur
-
-    if (process.env.NO_ANSI === 'false') {
-      kleur.enabled = false
-    }
+    kleur.enabled = process.env.NO_ANSI === 'false'
 
     /**
      * List of icons

src/Kernel/index.js

@@ -425,15 +425,15 @@ commander.Command.prototype.outputHelp = function () {
 /**
  * Listen for global ansi option
  */
-commander.on('ansi', function () {
+commander.on('option:ansi', function () {
   process.env.NO_ANSI = this.ansi
 })
 
 /* istanbul ignore next */
 /**
  * Listen for global env option
  */
-commander.on('env', function (env) {
+commander.on('option:env', function (env) {
   process.env.NODE_ENV = env
 })