Using uuid.v4() instead of uuid.v1() #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generate modified in this change seems to be what is generating API (and session?) tokens. If this is the case, then I believe that using the v4() method instead of v1() would be more desirable as it would provide higher entropy and so be harder to reproduce. v4() is completely random while v1() is time-based.
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generate method modified in this change seems to be what is generating API (and session?) tokens. If this is the case, then I believe that using the v4() method instead of v1() would be more desirable as it would provide higher entropy and so be harder to reproduce. v4() is completely random while v1() is time-based.