This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
feat(serve): add ignore options #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetutlage
approved these changes
Aug 19, 2018
src/Commands/Serve/index.js
Outdated
| @@ -164,6 +165,19 @@ class Serve extends Command { | |||
| } | |||
|
|
|||
| const nodemon = require('nodemon') | |||
| const foldersToIgnore = [ | |||
There was a problem hiding this comment.
I believe, we can make it little bit more organized. Also their is no need to add * to user defined ignore values, since it removes the flexibility of defining custom blobs.
The following feels more approachable to me
['/tmp/*', '/resources/*', '/public/*'].concat(ignore || []).map((folder) => `${process.cwd()}/${folder}`)
thetutlage
suggested changes
Aug 19, 2018
thetutlage
suggested changes
Aug 19, 2018
|
I believe we should keep the default ignored folders and simply concat the value. The requested change has been done. 馃憤 |
|
up? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢
This PR add two things.
Per default we don't watch the folder
resources, this folder should only contain frontend stuff or compiled assets. There's no need to reboot the whole server when they change.It's adding the
--ignoreflag to theservecommand. It let us set custom path to be ignored bynodemon.How to use it?
This command will ignore the default ignored folder +
nuxt,myCustomandnext.