Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

fix(deps): upgrade nodemon #117

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

iam4x
Copy link
Contributor

@iam4x iam4x commented Nov 27, 2018

The nodemon utility was not direclty dependent of event-stream
but it was still impacted by the event-stream hack.

See: dominictarr/event-stream#116

The `nodemon` utility was not direclty dependent of `event-stream`
but it was still impacted by the `event-stream` hack.

See: dominictarr/event-stream#116
@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.438% when pulling 98ed68c on iam4x:fix/eventstream-compromised into fac7e76 on adonisjs:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.438% when pulling 98ed68c on iam4x:fix/eventstream-compromised into fac7e76 on adonisjs:develop.

@RomainLanz
Copy link
Member

Thank you @iam4x.

In fact, the target version ^1.18.4 already includes 1.18.7 (it includes all version 1.18.X).

I don't believe we need to update this.

@iam4x
Copy link
Contributor Author

iam4x commented Nov 27, 2018

Yes it already includes the version, but releasing a new version will raise awareness to users about this hack.

You can have an old version in your node_modules and still be impacted, that was my case.

@thetutlage thetutlage merged commit 8a77564 into adonisjs:develop Nov 27, 2018
@thetutlage
Copy link
Member

Thanks 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants