Sessions now support cookie options #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implmented support for cookie options, while setting up session
| * which will be used by response object | ||
| * while making response | ||
| * @type {Object} | ||
| */ | ||
| const session = {key:this.constructor.sessionKey,value:sessionId} | ||
| const session = {key:this.constructor.sessionKey,value:sessionId, options} |
There was a problem hiding this comment.
Line is too long.
'const' is available in ES6 (use esnext option) or Mozilla JS extensions (use moz).
'object short notation' is available in ES6 (use esnext option) or Mozilla JS extensions (use moz).
Missing semicolon.
thetutlage
added a commit
that referenced
this pull request
Dec 10, 2015
Sessions now support cookie options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implmented support for cookie options, while setting up session