Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Allow for yarn workspaces #7

Closed
wants to merge 1 commit into from
Closed

Allow for yarn workspaces #7

wants to merge 1 commit into from

Conversation

acydwarp
Copy link

@acydwarp acydwarp commented Jan 7, 2018

Adonis makes the assumption that node_modules will always be in the app root. With yarn workspaces or monorepo setups, it's not in the app root, but in the project root instead. This PR makes it possible to use adonis in such environments.

@coveralls
Copy link

coveralls commented Jan 7, 2018

Coverage Status

Coverage remained the same at 94.399% when pulling 1ff596e on acydwarp:develop into cbc80e5 on adonisjs:develop.

@coveralls
Copy link

coveralls commented Jan 7, 2018

Coverage Status

Coverage remained the same at 94.399% when pulling d824623 on acydwarp:develop into cbc80e5 on adonisjs:develop.

@thetutlage
Copy link
Member

Then how to do handle shared dependencies between mono repos, when all dependencies are in the root?

@thetutlage thetutlage closed this Jan 25, 2018
@thetutlage
Copy link
Member

Closed PR. After reading the yarn docs, there are couple of issues with it.

They hoist all the dependencies to the root level, which will never work with AdonisJs, and here's why.

The IoC container needs to have a single instance per application, now if you have 3 applications and @adonisjs/fold is living in the root of all the 3 applications, then it will breaks, since 3 apps are sharing the same IoC container.

Use lernajs, they handle it without hositing apps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants