Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(belongsToMany): add countDistinct method #224

Merged
merged 3 commits into from
Nov 7, 2017
Merged

feat(belongsToMany): add countDistinct method #224

merged 3 commits into from
Nov 7, 2017

Conversation

webdevian
Copy link
Contributor

@coveralls
Copy link

coveralls commented Nov 7, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 95.586% when pulling c635984 on webdevian:develop into 2c6c56c on adonisjs:develop.

@coveralls
Copy link

coveralls commented Nov 7, 2017 •
edited

Coverage Status

Coverage increased (+0.01%) to 95.89% when pulling 21c9fb8 on webdevian:develop into 2c6c56c on adonisjs:develop.

@coveralls
Copy link

coveralls commented Nov 7, 2017 •
edited

Coverage Status

Coverage increased (+0.4%) to 96.327% when pulling 0dbe277 on webdevian:develop into 2c6c56c on adonisjs:develop.

@webdevian webdevian closed this Nov 7, 2017
@webdevian webdevian reopened this Nov 7, 2017
@coveralls
Copy link

coveralls commented Nov 7, 2017 •
edited

Coverage Status

Coverage increased (+0.4%) to 96.327% when pulling 0dbe277 on webdevian:develop into 2c6c56c on adonisjs:develop.

@webdevian
Copy link
Contributor Author

@thetutlage @RomainLanz Tests seem to be flaky :/

@thetutlage
Copy link
Member

I believe the tests get flaky, since 2 travis builds are using the same Sqlite file in parallel. I have made it to run one build at a time

@thetutlage thetutlage merged commit 26cca0e into adonisjs:develop Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@webdevian @coveralls @thetutlage @RomainLanz