Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CountDistinct method missing from belongsToMany relationships #221

Closed
webdevian opened this issue Nov 7, 2017 · 1 comment
Closed

CountDistinct method missing from belongsToMany relationships #221

webdevian opened this issue Nov 7, 2017 · 1 comment
Assignees
@webdevian

Comments

@webdevian
Copy link
Contributor

Creating a separate issue from #216, I will do a PR later in the week
@thetutlage
Copy link
Member

👍

webdevian pushed a commit to webdevian/adonis-lucid that referenced this issue Nov 7, 2017
feat(belongsToMany): add countDistinct method
c635984 
adonisjs#221
@webdevian webdevian mentioned this issue Nov 7, 2017
Merged
thetutlage pushed a commit that referenced this issue Nov 7, 2017
@webdevian @thetutlage
feat(belongsToMany): add countDistinct method (#224)
26cca0e 
* feat(belongsToMany): add countDistinct method

#221

* test(belongsToMany): test for countDistinct

* refactor(belongsToMany): remove duplicate code in aggregate methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webdevian webdevian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thetutlage @RomainLanz @webdevian