Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add assembler configuration (unstable) #32

Merged
merged 7 commits into from
Feb 24, 2024

Conversation

Julien-R44
Copy link
Member

@Julien-R44 Julien-R44 commented Feb 22, 2024

Added configuration for assembly as explained in this issue https://github.com/adonisjs/insiders/issues/3

Several changes compared to the original RFC:

  • hooks must be defined in different files and default exported, as recommended by Virk
  • assembler.runner defines the command to be executed to launch the dev server or tests. Just an object in which to define the command and its arguments

The code that will manage the import of hook files and their application will live in adonisjs/assembler. I hesitated on this one, but after reflection I think it's the best decision

  • the code will be more or less similar to this https://github.com/japa/runner/blob/develop/src/hooks.ts + we also need to import hooks file.
  • This code will super specific to the assembler. It makes more sense to me that it lives in the assembler repo. A modification to it will probably also imply a modification to the assembler. So, from a maintenance point of view, it's easier to keep the two together. No release to do between adonisjs/application and adonisjs/assembler.
  • It's not very important because there's not a lot of code, but this code will only be needed for development, so probably better to have it in adonisjs/assembler, which isn't installed in production.

@Julien-R44
Copy link
Member Author

i have simplified the thing by removing a few hooks that won't be useful right now

also added the unstable flag. So in the adonisrc.ts file we need to use unstable_assembler: { ... }

Base automatically changed from feat/disable-bundler to develop February 24, 2024 10:39
@Julien-R44 Julien-R44 changed the title feat: add assembler configuration feat: add assembler configuration (unstable) Feb 24, 2024
@Julien-R44 Julien-R44 merged commit 0eee9f9 into develop Feb 24, 2024
12 checks passed
@Julien-R44 Julien-R44 deleted the feat/assembler-config branch February 24, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant