Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AccessTokenDbColumns abilities type #238

Closed
wants to merge 1 commit into from

Conversation

llucasspot
Copy link

@llucasspot llucasspot commented Mar 10, 2024

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

Hello @llucasspot

Can you please first explain the issue? Also make sure to add a test that reproduces the bug before you provide the fix

@thetutlage thetutlage self-requested a review March 11, 2024 05:32
@RomainLanz
Copy link
Member

This seems to be the explanation of the issue, but as Aman said, we first need a test that shows the issue.

@llucasspot
Copy link
Author

llucasspot commented Mar 11, 2024

sorry, I didnt link the issue and the PR

My mistake, my access token migration file used json and not text for the abilities column (maybe a forgotten change when i was migrating v5 to v6)

I close the ticket
thx

@llucasspot llucasspot closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants