refactor: cleanup code

src/Ignitor/Ace/AppCommands.ts

@@ -24,6 +24,11 @@ export class AppCommands {
    */
   private _wired = false
 
+  /**
+   * Signals listener to listen for exit signals and kill command
+   */
+  private _signalsListener = new SignalsListener()
+
   /**
    * Source root always points to the compiled source
    * code.
@@ -34,6 +39,25 @@ export class AppCommands {
   ) {
   }
 
+  /**
+   * Hooks into kernel lifecycle events to conditionally
+   * load the app.
+   */
+  private _addKernelHooks (kernel: ace.Kernel) {
+    kernel.before('find', async (command) => {
+      if (command && command.settings.loadApp) {
+        await this._wire()
+        this._bootstrapper.application.isReady = true
+      }
+    })
+
+    kernel.before('run', async () => {
+      if (this._wired) {
+        await this._bootstrapper.executeReadyHooks()
+      }
+    })
+  }
+
   /**
    * Boot the application.
    */
@@ -61,24 +85,12 @@ export class AppCommands {
 
     const manifest = new this._ace.Manifest(this._sourceRoot)
     const kernel = new this._ace.Kernel(this._bootstrapper.application)
-
-    kernel.before('find', async (command) => {
-      if (command && command.settings.loadApp) {
-        await this._wire()
-        this._bootstrapper.application.isReady = true
-      }
-    })
-
-    kernel.before('run', async () => {
-      if (this._wired) {
-        await this._bootstrapper.executeReadyHooks()
-      }
-    })
+    this._addKernelHooks(kernel)
 
     kernel.useManifest(manifest)
     await kernel.handle(argv)
 
-    new SignalsListener().listen(async () => {
+    this._signalsListener.listen(async () => {
       if (this._wired) {
         await this._bootstrapper.executeShutdownHooks()
       }

src/Ignitor/Ace/GenerateManifest.ts

@@ -9,7 +9,6 @@
 
 import ace from '@adonisjs/ace'
 import { Bootstrapper } from '../Bootstrapper'
-import { exitProcess } from '../../utils'
 
 /**
  * Exposes the API to generate the manifest file
@@ -52,6 +51,5 @@ export class GenerateManifest {
      * Success
      */
     this._ace.logger.create('.adonisrc.json')
-    exitProcess(0)
   }
 }

src/Ignitor/Bootstrapper.ts

@@ -185,6 +185,7 @@ export class Bootstrapper {
    * Executes the ready hooks on the providers
    */
   public async executeReadyHooks () {
+    this._logger!.trace('executing ready hooks')
     await Promise.all(this._providersWithReadyHook.map((provider) => provider.ready()))
     this._providersWithReadyHook = []
   }
@@ -193,6 +194,7 @@ export class Bootstrapper {
    * Executes the ready hooks on the providers
    */
   public async executeShutdownHooks () {
+    this._logger!.trace('executing shutdown hooks')
     await Promise.all(this._providersWithShutdownHook.map((provider) => provider.shutdown()))
     this._providersWithShutdownHook = []
   }

src/Ignitor/HttpServer.ts

@@ -203,7 +203,7 @@ export class HttpServer {
       this._monitorHttpServer()
       this._signalsListener.listen(() => this.close())
     } catch (error) {
-      new ErrorHandler(this.application).handleError(error).finally(() => process.exit(1))
+      new ErrorHandler(this.application).handleError(error)
     }
   }
 
@@ -219,8 +219,6 @@ export class HttpServer {
      * we are not accepting any new request during cool off.
      */
     await this._closeHttpServer()
-
-    this._logger.trace('preparing server shutdown')
     await this._bootstrapper.executeShutdownHooks()
   }
 
@@ -230,6 +228,8 @@ export class HttpServer {
    * seconds.
    */
   public async kill (waitTimeout: number = 3000) {
+    this._logger.trace('forcefully killing http server')
+
     try {
       await Promise.race([this.close(), new Promise((resolve) => {
         setTimeout(resolve, waitTimeout)