refactor: fix failing tests

src/Ignitor/Ace.ts

@@ -21,6 +21,16 @@ export class Ace {
   constructor (private _ignitor: Ignitor) {
   }
 
+  /**
+   * Exit process conditionally
+   */
+  private _exitProcess (signal) {
+    if (process.env.NODE_ENV === 'testing') {
+      return
+    }
+    process.exit(signal)
+  }
+
   /**
    * Prints the ascii logo
    */
@@ -49,7 +59,7 @@ export class Ace {
       console.log(`Framework version: ${this._ignitor.application.adonisVersion?.version || 'NA'}`)
       console.log(`App version: ${this._ignitor.application.version?.version || 'NA'}`)
       console.log('')
-      process.exit(0)
+      this._exitProcess(0)
     }, {})
   }
 
@@ -60,7 +70,7 @@ export class Ace {
     this._dumpAsciiLogo()
     kernel.printHelp(command)
     console.log('')
-    process.exit(0)
+    this._exitProcess(0)
   }
 
   /**
@@ -84,10 +94,10 @@ export class Ace {
        */
       command.logger.create('ace-manifest.json')
 
-      process.exit(0)
+      this._exitProcess(0)
     } catch (error) {
       await new ErrorHandler(this._ignitor.application).handleError(error)
-      process.exit(1)
+      this._exitProcess(1)
     }
   }
 
@@ -149,7 +159,7 @@ export class Ace {
      */
     if (argv[0] === 'generate:manifest') {
       class Noop extends BaseCommand {}
-      this._generateManifest(manifest, new Noop())
+      await this._generateManifest(manifest, new Noop())
       return
     }
 
@@ -162,7 +172,7 @@ export class Ace {
         await this._bootstrap(command)
       } catch (error) {
         await new ErrorHandler(this._ignitor.application).handleError(error)
-        process.exit(1)
+        this._exitProcess(1)
       }
     })
 
@@ -178,7 +188,7 @@ export class Ace {
       await kernel.handle(argv)
     } catch (error) {
       handleError(error)
-      process.exit(1)
+      this._exitProcess(1)
     }
   }
 }

src/Ignitor/Bootstrapper.ts

@@ -56,7 +56,7 @@ export class Bootstrapper {
     global[Symbol.for('ioc.call')] = ioc.call.bind(ioc)
 
     const adonisCorePkgFile = findPkg(join(__dirname, '..', '..')).next().value
-    const appPkgFile = findPkg(this._application.appRoot).next().value
+    const appPkgFile = findPkg(this._appRoot).next().value
 
     const pkgFile = {
       name: appPkgFile.name,

src/Ignitor/index.ts

@@ -87,6 +87,16 @@ export class Ignitor {
     this._errorHandler = new ErrorHandler(this.application)
   }
 
+  /**
+   * Exit process conditionally
+   */
+  private _exitProcess (signal) {
+    if (process.env.NODE_ENV === 'testing') {
+      return
+    }
+    process.exit(signal)
+  }
+
   /**
    * Executes the ready hooks when the application is ready.
    *
@@ -132,19 +142,19 @@ export class Ignitor {
       process.on('SIGINT', async () => {
         try {
           await this.close()
-          process.exit(0)
+          this._exitProcess(0)
         } catch (error) {
-          process.exit(1)
+          this._exitProcess(1)
         }
       })
     }
 
     process.on('SIGTERM', async () => {
       try {
         await this.close()
-        process.exit(0)
+        this._exitProcess(0)
       } catch (error) {
-        process.exit(1)
+        this._exitProcess(1)
       }
     })
   }
@@ -245,7 +255,7 @@ export class Ignitor {
       await this._httpServer.start()
     } catch (error) {
       await this._errorHandler.handleError(error)
-      process.exit(1)
+      this._exitProcess(1)
     }
   }
 
@@ -286,10 +296,10 @@ export class Ignitor {
       await Promise.race([this._prepareShutDown(), new Promise((resolve) => {
         setTimeout(resolve, waitTimeout)
       })])
-      process.exit(0)
+      this._exitProcess(0)
     } catch (error) {
       await this._errorHandler.handleError(error)
-      process.exit(1)
+      this._exitProcess(1)
     }
   }
 }

test/ignitor-boostrapper.spec.ts

@@ -23,13 +23,18 @@ test.group('Ignitor | Setup', (group) => {
     process.env.ENV_SILENT = 'true'
   })
 
+  group.beforeEach(() => {
+    process.env.NODE_ENV = 'testing'
+  })
+
   group.after(async () => {
     await fs.cleanup()
     delete process.env.ENV_SILENT
     delete process.env.APP_KEY
   })
 
   group.afterEach(async () => {
+    delete process.env.NODE_ENV
     await fs.cleanup()
   })
 

test/ignitor.spec.ts

@@ -25,13 +25,18 @@ test.group('Ignitor | App Provider', (group) => {
     process.env.ENV_SILENT = 'true'
   })
 
+  group.beforeEach(() => {
+    process.env.NODE_ENV = 'testing'
+  })
+
   group.after(async () => {
     await fs.cleanup()
     delete process.env.ENV_SILENT
     delete process.env.APP_KEY
   })
 
   group.afterEach(async () => {
+    delete process.env.NODE_ENV
     await fs.cleanup()
   })
 
@@ -104,13 +109,18 @@ test.group('Ignitor | Http', (group) => {
     process.env.ENV_SILENT = 'true'
   })
 
+  group.beforeEach(() => {
+    process.env.NODE_ENV = 'testing'
+  })
+
   group.after(async () => {
     await fs.cleanup()
     delete process.env.ENV_SILENT
     delete process.env.APP_KEY
   })
 
   group.afterEach(async () => {
+    delete process.env.NODE_ENV
     await fs.cleanup()
   })
 
@@ -315,7 +325,12 @@ test.group('Ignitor | Ace', (group) => {
     await fs.cleanup()
   })
 
+  group.beforeEach(() => {
+    process.env.NODE_ENV = 'testing'
+  })
+
   group.afterEach(async () => {
+    delete process.env.NODE_ENV
     await fs.cleanup()
   })
 
@@ -326,15 +341,15 @@ test.group('Ignitor | Ace', (group) => {
     await fs.add('ace-manifest.json', JSON.stringify({
       foo: {
         commandName: 'foo',
-        commandPath: 'fooCommand',
+        commandPath: './fooCommand',
       },
     }))
 
     await fs.add('fooCommand.ts', `export default class FooCommand {
       public static args = []
       public static flags = []
 
-      public static boot () {
+      public static $boot () {
       }
 
       public handle () {
@@ -350,7 +365,7 @@ test.group('Ignitor | Ace', (group) => {
     await fs.add('ace-manifest.json', JSON.stringify({
       foo: {
         commandName: 'foo',
-        commandPath: 'foo.ts',
+        commandPath: './foo.ts',
         settings: {
           loadApp: true,
         },
@@ -361,7 +376,7 @@ test.group('Ignitor | Ace', (group) => {
       public static args = []
       public static flags = []
 
-      public static boot () {
+      public static $boot () {
       }
 
       public handle () {
@@ -386,17 +401,6 @@ test.group('Ignitor | Ace', (group) => {
   })
 
   test('generate manifest file', async (assert) => {
-    const ignitor = new Ignitor(fs.basePath)
-    await fs.fsExtra.ensureDir(join(fs.basePath, 'config'))
-
-    await fs.add('providers/AppProvider.ts', `
-      import { join } from 'path'
-
-      export default class AppProvider {
-        public commands = [join(__dirname, '..', 'commands', 'Foo.ts')]
-      }
-    `)
-
     await fs.add('commands/Foo.ts', `
       export default class Foo {
         public static commandName = 'foo'
@@ -405,7 +409,7 @@ test.group('Ignitor | Ace', (group) => {
         public static args = []
         public static flags = []
 
-        public static boot () {
+        public static $boot () {
         }
 
         public handle () {
@@ -415,82 +419,25 @@ test.group('Ignitor | Ace', (group) => {
 
     await fs.add(`start/app.ts`, `export const providers = [
       '${join(__dirname, '../providers/AppProvider.ts')}',
-      '${join(fs.basePath, 'providers/AppProvider.ts')}',
     ]`)
 
     await fs.add(`config/app.ts`, `export const appKey = '${SECRET}'`)
-
     await fs.add('.adonisrc.json', JSON.stringify({
       autoloads: {
         'App': './app',
       },
+      commands: ['./commands/Foo'],
     }))
 
-    await ignitor.handleAceCommand(['generate:manifest'])
-    assert.isTrue(ignitor.bootstraped)
-
-    const manifestFile = await fs.get('ace-manifest.json')
-    assert.deepEqual(JSON.parse(manifestFile), {
-      foo: {
-        settings: {},
-        commandPath: join(fs.basePath, 'commands/Foo'),
-        commandName: 'foo',
-        description: 'Print foo',
-        args: [],
-        flags: [],
-      },
-    })
-  })
-
-  test('load commands from start/app file', async (assert) => {
     const ignitor = new Ignitor(fs.basePath)
-
-    await fs.fsExtra.ensureDir(join(fs.basePath, 'config'))
-
-    await fs.add('commands/Foo.ts', `
-      export default class Foo {
-        public static commandName = 'foo'
-        public static description = 'Print foo'
-
-        public static args = []
-        public static flags = []
-
-        public static boot () {
-        }
-
-        public handle () {
-        }
-      }
-    `)
-
-    await fs.add(`start/app.ts`, `
-      import { join } from 'path'
-
-      export const providers = [
-        '${join(__dirname, '../providers/AppProvider.ts')}',
-      ]
-
-      export const commands = [
-        join(__dirname, '..', 'commands', 'Foo.ts')
-      ]
-    `)
-
-    await fs.add(`config/app.ts`, `export const appKey = '${SECRET}'`)
-
-    await fs.add('.adonisrc.json', JSON.stringify({
-      autoloads: {
-        'App': './app',
-      },
-    }))
-
     await ignitor.handleAceCommand(['generate:manifest'])
     assert.isTrue(ignitor.bootstraped)
 
     const manifestFile = await fs.get('ace-manifest.json')
     assert.deepEqual(JSON.parse(manifestFile), {
       foo: {
         settings: {},
-        commandPath: join(fs.basePath, 'commands/Foo'),
+        commandPath: './commands/Foo',
         commandName: 'foo',
         description: 'Print foo',
         args: [],