refactor: properly handle http server port in use error

adonisjs · Nov 22, 2019 · 263a503 · 263a503
1 parent e2ca688
commit 263a503
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/Ignitor/HttpServer/index.ts b/src/Ignitor/HttpServer/index.ts
@@ -130,8 +130,7 @@ export class HttpServer {
 
     this._server.instance!.on('error', async (error: NodeJS.ErrnoException) => {
       if (error.code === 'EADDRINUSE') {
-        this._server.instance!.close()
-        return
+        this._logger.trace(`Port in use, closing server`)
       }
 
       await this.kill(3000)
@@ -199,8 +198,8 @@ export class HttpServer {
       this._setLogger()
       this._setServer()
       this.createServer(serverCallback)
-      await this.listen()
       this._monitorHttpServer()
+      await this.listen()
       this._signalsListener.listen(() => this.close())
     } catch (error) {
       new ErrorHandler(this.application).handleError(error)