feat(ignitor): validate engines.node version (if defined) against cur…

…rent node.js version

package.json

@@ -109,6 +109,7 @@
     "ms": "^2.1.2",
     "on-finished": "^2.3.0",
     "randomstring": "^1.1.5",
+    "semver": "^7.1.3",
     "serve-static": "^1.14.1"
   },
   "peerDependencies": {

src/Ignitor/Bootstrapper/index.ts

@@ -8,6 +8,7 @@
 */
 
 import { join } from 'path'
+import semver from 'semver'
 import findPkg from 'find-package-json'
 import { esmRequire } from '@poppinss/utils'
 import { Ioc, Registrar } from '@adonisjs/fold'
@@ -54,6 +55,24 @@ export class Bootstrapper {
   ) {
   }
 
+  /**
+   * If package.json file defines a the engines.node property, then
+   * this method will ensure that current node version satisfies
+   * the defined range.
+   */
+  private verifyNodeJsVersion (pkgFile?: findPkg.Package): void {
+    const nodeEngine = pkgFile?.engines?.node
+    if (!nodeEngine) {
+      return
+    }
+
+    if (!semver.satisfies(process.version, nodeEngine)) {
+      throw new Error(
+        `The installed Node.js version "${process.version}" does not satisfies the expected version "${nodeEngine}" defined inside package.json file`,
+      )
+    }
+  }
+
   /**
    * Setup the Ioc container globals and the application. This lays
    * off the ground for not having `global.use` runtime errors.
@@ -99,6 +118,8 @@ export class Bootstrapper {
     this.application = new Application(this.appRoot, ioc, rcContents, pkgFile)
     this.registrar = new Registrar(ioc, this.appRoot)
 
+    this.verifyNodeJsVersion(appPkgFile)
+
     ioc.singleton('Adonis/Core/Application', () => this.application)
     return this.application
   }

test/ignitor-boostrapper.spec.ts

@@ -39,6 +39,15 @@ test.group('Ignitor | Setup', (group) => {
     await fs.cleanup()
   })
 
+  test('raise error when node engine inside package.json file doesn\'t satisfies current verison', async (assert) => {
+    await setupApplicationFiles(fs)
+    const bootstrapper = new Bootstrapper(fs.basePath)
+    await fs.add('package.json', JSON.stringify({ engines: { node: '4.x.x' } }))
+    const fn = () => bootstrapper.setup()
+    // eslint-disable-next-line max-len
+    assert.throw(fn, `The installed Node.js version \"${process.version}\" does not satisfies the expected version \"4.x.x\" defined inside package.json file`)
+  })
+
   test('setup application', async (assert) => {
     await setupApplicationFiles(fs)
     const bootstrapper = new Bootstrapper(fs.basePath)