Cannot find module 'phc-bcrypt'

[msrumon]

Another bug (coming from user signup functionality):

Cannot find module 'phc-bcrypt'
Require stack:
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\hash\build\src\Drivers\Bcrypt.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\hash\build\src\Hash\index.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\hash\build\providers\HashProvider.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@poppinss\utils\build\src\esmRequire.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@poppinss\utils\build\index.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\fold\build\src\Ioc\index.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\fold\build\index.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\core\build\src\Ignitor\Bootstrapper\index.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\core\build\src\Ignitor\Ace\AppCommands.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\core\build\src\Ignitor\Ace\index.js
- C:\Users\msris\Documents\projects\galaxnetpictures\node_modules\@adonisjs\core\build\src\Ignitor\index.js
- C:\Users\msris\Documents\projects\galaxnetpictures\build\server.js

This happens for both the bcrypt and argon drivers.

[thetutlage]

This is not an issue. You have to install the bcrypt driver for it work. Also mentioned as comment in the config file

[msrumon]

Oh so it has to be installed manually? Then how did it work on preview version 1.09?

[msrumon]

This is my config/hash.ts file:

/**
 * Config source: https://git.io/JfefW
 *
 * Feel free to let us know via PR, if you find something broken in this config
 * file.
 */

import { HashConfig } from '@ioc:Adonis/Core/Hash'

/*
|--------------------------------------------------------------------------
| Hash Config
|--------------------------------------------------------------------------
|
| The `HashConfig` relies on the `HashList` interface which is
| defined inside `contracts` directory.
|
*/
const hashConfig: HashConfig = {
  /*
  |--------------------------------------------------------------------------
  | Default hasher
  |--------------------------------------------------------------------------
  |
  | By default we make use of the bcrypt hasher to hash values. However, feel
  | free to change the default value
  |
  */
  default: 'bcrypt',

  list: {
    /*
    |--------------------------------------------------------------------------
    | Argon
    |--------------------------------------------------------------------------
    |
    | Argon mapping uses the `argon2` driver to hash values.
    |
    | Make sure you install the underlying dependency for this driver to work.
    | https://www.npmjs.com/package/@phc/argon2.
    |
    | npm install @phc/argon2@"<2.0.0"
    |
    */
    argon: {
      driver: 'argon2',
      variant: 'id',
      iterations: 3,
      memory: 4096,
      parallelism: 1,
      saltSize: 16,
    },

    /*
    |--------------------------------------------------------------------------
    | Bcrypt
    |--------------------------------------------------------------------------
    |
    | Bcrypt mapping uses the `bcrypt` driver to hash values.
    |
    | Make sure you install the underlying dependency for this driver to work.
    | https://www.npmjs.com/package/@phc/bcrypt.
    |
    | npm install @phc/bcrypt@"<2.0.0"
    |
    */
    bcrypt: {
      driver: 'bcrypt',
      rounds: 10,
    },
  },
}

export default hashConfig

And I don't see the line you've mentioned.

[msrumon]

Misleading information:

/**
 * Config source: https://git.io/JfefW
 *
 * Feel free to let us know via PR, if you find something broken in this config
 * file.
 */

import Env from '@ioc:Adonis/Core/Env'
import { HashConfig } from '@ioc:Adonis/Core/Hash'

/*
|--------------------------------------------------------------------------
| Hash Config
|--------------------------------------------------------------------------
|
| The `HashConfig` relies on the `HashList` interface which is
| defined inside `contracts` directory.
|
*/
const hashConfig: HashConfig = {
  /*
  |--------------------------------------------------------------------------
  | Default hasher
  |--------------------------------------------------------------------------
  |
  | By default we make use of the bcrypt hasher to hash values. However, feel
  | free to change the default value
  |
  */
  default: Env.get('HASH_DRIVER', 'argon') as 'argon',
  // you're telling 'bcrypt' as default hash driver, but set 'argon' as default here

  list: {
    /*
    |--------------------------------------------------------------------------
    | Argon
    |--------------------------------------------------------------------------
    |
    | Argon mapping uses the `argon2` driver to hash values.
    |
    | Make sure you install the underlying dependency for this driver to work.
    | https://www.npmjs.com/package/phc-argon2.
    |
    | npm install phc-argon2
    |
    */
    argon: {
      driver: 'argon2',
      variant: 'id',
      iterations: 3,
      memory: 4096,
      parallelism: 1,
      saltSize: 16,
    },

    /*
    |--------------------------------------------------------------------------
    | Bcrypt
    |--------------------------------------------------------------------------
    |
    | Bcrypt mapping uses the `bcrypt` driver to hash values.
    |
    | Make sure you install the underlying dependency for this driver to work.
    | https://www.npmjs.com/package/phc-bcrypt.
    |
    | npm install phc-bcrypt
    |
    */
    bcrypt: {
      driver: 'bcrypt',
      rounds: 10,
    },
  },
}

export default hashConfig

Wondering how did I get this? By running node ace invoke @adonisjs/core. If you make breaking changes, at least let others know about it.

[thetutlage]

The framework is in preview so do expect things to break here and there during release.

And it is not such a huge breaking change that required many changes.

[aspraveen]

I just updated to release 5.0.0-preview-rc-1.11 and the following error popped up

Cannot find module 'phc-argon2'

Even though I fixed it using NPM install php-argon2, I wonder why I had to manually install it this time where it was working fine in the previous version?

Just trying to understand.

[msrumon]

No, that's not it. Previously they used @phc/bcrypt and @phc/argon2, and both came pre-installed. Now they switched to their own forked versions of the packages w/ updated dependencies. This caused problem. The worse thing is: they never got to mention anywhere that the release has possible breaking changes. If we would get this warning before, we would test diagnose the whole site before publishing. Because of that, one of my production site suddenly had broken, and it took a whole day for me to fix. Pathetic!

[thetutlage]

Dude, I don't get why you are whinning for no reasons. Already mentioned in the same thread that, this is a preview relases and small issues can happen.

And mind your words and think twice before calling someone pathetic

[thetutlage]

Instead of whining, you can also standup and lead to write the docs around same, which we eventually did. https://preview.adonisjs.com/releases/core/preview-rc-1_7#breaking-change

[ghost]

You broke @adonisjs/auth package again. Where have you mentioned about this? People are not bound to search release notes for breaking changes, unless you give them the hint. You could've avoided the situation in the first place if you provided the link of release note beforehand. I hope you'll suffer one day for your deed. Goodbye!

[RomainLanz]

No need to become disrespectful. 😉