Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the license badge in README.md pointing to an invalid URL #1161

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

nayefalebrahim
Copy link
Contributor

@nayefalebrahim nayefalebrahim commented Nov 1, 2019

#1160

Proposed changes

Purely an update to the shields.io license image to show "MIT License" as it currently shows "Package not found".

Types of changes

An updated shields.io URL for the license-image in README.md which tracks the repository license and shows the relevant image.

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

Just a note to the maintainers regarding shields.io rate limits:

If your GitHub badge errors, it might be because you hit GitHub's rate limits. You can increase Shields.io's rate limit by adding the Shields GitHub application using your GitHub account.

It's a trivial change, I found Adonis after looking for Laravel like frameworks for node. the "Package not found" made me think something is broken/outdated, then I realized that it's just the license image. Just wanted to help out, Can't wait to dive into Adonis!

@thetutlage thetutlage merged commit 4dd6a94 into adonisjs:develop Nov 7, 2019
@thetutlage
Copy link
Member

Thanks 😄

@thetutlage thetutlage self-assigned this Nov 7, 2019
@thetutlage thetutlage added Status: Completed The work has been completed, but not released yet Type: Enhancement Improving an existing feature labels Nov 7, 2019
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Completed The work has been completed, but not released yet Type: Enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants