fix(server): correctly handle errors on listen

[targos]

The Promise constructor doesn't automatically catch errors if its handler
function is async. Use try/catch to avoid unhandled rejections.
If the server is closed because the port is already in used, use a
non-zero exit code and log it as an error.

[thetutlage]

Is it mainly to handle the exceptions raised by the readyHooks?

[targos]

@thetutlage yes

[targos]

but the same reasoning can be used for the other lines, in case they result in a thrown error (for example if server.listen() gets wrong values as its port or host arguments)

[thetutlage]

Thanks 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.