Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to bind to an host #22

Merged
merged 1 commit into from Dec 5, 2015
Merged

add possibility to bind to an host #22

merged 1 commit into from Dec 5, 2015

Conversation

RomainLanz
Copy link
Member

Implement feature #4

I have also make this spec more consistent.

Alternative

Server.prototype.start = function (port, host) {
  host = host || '0.0.0.0'
  this.Logger.info('serving app on port %s', port)
  this.serverInstance.listen(port, host)
}

If we implement the alternative we don't need to change tests.

Mirror PR: adonisjs/adonis-app#1

Implement feature #4

I have also make this spec more consistent.
this.Logger.info('serving app on port %s', port)
this.serverInstance.listen(port)
this.serverInstance.listen(port, host)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

thetutlage added a commit that referenced this pull request Dec 5, 2015
add possibility to bind to an host
@thetutlage thetutlage merged commit d7323b9 into adonisjs:master Dec 5, 2015
@RomainLanz RomainLanz deleted the add-binding-to-host branch December 7, 2015 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants